OCO orders are broken on a spot market

[tripolskypetr]

I noticed stop loss orders are broken on a spot market(

orderStatus = await binance.sell("BTCUSDT", 0.0008, 111936, {
    stopPrice: 113672,
    stopLimitPrice: 113672,
    stopLimitTimeInForce: "GTC",
    type: "OCO",
});

Getting an error

734 |         // if (typeof params.icebergQty !== 'undefined') request.icebergQty = params.icebergQty;
735 |         if (params.stopPrice) {
736 |             request.stopPrice = params.stopPrice;
737 |             if (request.type === 'LIMIT')
738 |                 throw Error('stopPrice: Must set "type" to one of the following: STOP_LOSS, STOP_LOSS_LIMIT, TAKE_PROFIT, TAKE_PROFIT_LIMIT');
                            ^
error: stopPrice: Must set "type" to one of the following: STOP_LOSS, STOP_LOSS_LIMIT, TAKE_PROFIT, TAKE_PROFIT_LIMIT
      at order (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:738:23)
      at order (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:688:17)
      at sell (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:775:27)
      at sell (C:\Users\User\Documents\GitHub\one-master\node_modules\node-binance-api\dist\node-binance-api.js:774:16)
      at <anonymous> (C:\Users\User\Documents\GitHub\one-master\build\index.mjs:16541:33)

Could you please update relevant example cause all sources from the internet gives me the code which does not work

@carlosmiei

[carlosmiei]

Hello @tripolskypetr,

Are you trying to place a trigger/stop limit order, or an OCO order?

[tripolskypetr]

Hey! Trying to create OCO order so only the take-profit ($113_500) or the stop-loss ($109_450) will be executed like on this image

@carlosmiei

[tripolskypetr]

When I try to provide OCO as order type argument I am getting the typescript error

If I ignore this using any cast, the code will throw an error

await binance.order(
    "OCO" as any,
    "SELL",
    dto.symbol,
    Number(quantity),
    Number(price),
    {
      stopPrice: stopPrice,
      stopLimitPrice: stopLimitPrice,
      timeInForce: "GTC",
    }
  );

But the implementation of node-binance-api contains the code for handling OCO orders

P.S.

Problem is right now I have to use binance-api-node only for orderOco method.

This is nasty

import Binance from "node-binance-api";
import BinanceOco from "binance-api-node";

const orderOco = async (
  dto: {
    symbol: string;
    quantity: number;
    takeProfitPrice: number;
    stopLossPrice: number;
    stopLimitPrice: number;
  },
  binance: Binance
) => {
  const client = BinanceOco({
    apiKey: CC_BINANCE_API_KEY,
    apiSecret: CC_BINANCE_API_SECRET,
    getTime: async () => {
      const { serverTime } = await binance.time();
      return serverTime;
    },
  });
  return await client.orderOco({
    symbol: dto.symbol,
    side: "SELL",
    quantity: await formatQuantity(dto.symbol, dto.quantity, binance),
    price: await formatPrice(dto.symbol, dto.takeProfitPrice, binance),
    stopPrice: await formatPrice(dto.symbol, dto.stopLossPrice, binance),
    stopLimitPrice: await formatPrice(dto.symbol, dto.stopLimitPrice, binance),
  });
};

Really want to remove this. Tried to fix node-binance-api on my own but failed. Could you help me with that?

@carlosmiei

[tripolskypetr]

[carlosmiei]

@tripolskypetr We have released a new version with ocoOrder and there's an example here: https://github.com/ccxt/node-binance-api/blob/master/examples/oco-order.ts

Let us know if anything!