Should the `trades` stream delegate to the same endpoint rather than `aggTrades?

[dmitriz]

It seems that the ws.trades method delegates to the aggTrades endpoint:

https://github.com/HyperCubeProject/binance-api-node/blob/master/src/websocket.js#L165-L167

instead of using the trades endpoint as indicated in the readme:

https://github.com/HyperCubeProject/binance-api-node#trades-1

Is this a bug?

UPDATE: fixed the last link to point to WS rather than REST

[balthazar]

The websocket and http client api is not the same

[dmitriz]

@balthazar
Thanks, I have changed the Readme link now to this part from the websocket section:
https://github.com/HyperCubeProject/binance-api-node#trades-1

It is called "trades" but retrieves "aggTrades" instead:

client.ws.trades(['ETHBTC', 'BNBBTC'], trade => {
  console.log(trade)
})

Output

{
  eventType: 'aggTrade',
  eventTime: 1508614495052,
  symbol: 'ETHBTC',
  price: '0.04923600',
  quantity: '3.43500000',
  maker: false,
  tradeId: 2148226
}

On the other hand, the trades stream from the official doc has

Stream Name: <symbol>@trade

Payload:

{
  "e": "trade",     // Event type
  "E": 123456789,   // Event time
  "s": "BNBBTC",    // Symbol
  "t": 12345,       // Trade ID
  "p": "0.001",     // Price
  "q": "100",       // Quantity
  "b": 88,          // Buyer order Id
  "a": 50,          // Seller order Id
  "T": 123456785,   // Trade time
  "m": true,        // Is the buyer the market maker?
  "M": true         // Ignore.
}

That stream does not seem to be accessible at all from this library. Is that intentional?

[balthazar]

Indeed it's not, I believe the trade steam was previously not exposed by the API, and I simply called aggTrades trades. Will need to implement it and rename the other one. Thanks for the heads-up!

[numerized]

ReadMe is still showing errors.

client.ws.trades works perfectly.

Thanks for amazing lib.

TypeError: client.ws.aggTrades is not a function
at Object. (/var/www/html/00_boom_node/server.0.9.js:191:35)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Function.Module.runMain (module.js:693:10)
at startup (bootstrap_node.js:191:16)
at bootstrap_node.js:612:3

[balthazar]

Released 0.8.0.