Merged
Conversation
Member
Author
|
Confirmed now, this fixes dials/dials#2998 on Windows |
aaronfinke
pushed a commit
to aaronfinke/dxtbx
that referenced
this pull request
Oct 7, 2025
Preserve an imageset's reject list through pickling. Fixes dials/dials#2998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reject list of images to ignore in e.g. spotfinding was not being preserved by pickling, as found while investigating dials/dials#2998. This PR ensures the reject list is kept, which probably fixes that issue (though untested on Windows yet)