Add tof_helpers.InstrumentDefinitionReader#842
Merged
Conversation
…tion directly from xml data, and update FormatMANDI to use this by default.
toastisme
changed the title
aaronfinke
pushed a commit
to aaronfinke/dxtbx
that referenced
this pull request
Oct 7, 2025
Add tof_helpers.InstrumentDefinitionReader to read instrument information directly from xml data, and update FormatMANDI to use this by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOF NeXus files often contain instrument definitions in spherical coordinates. This can be preferable to use compared to hardcoded values as they often change over time. This adds a class to
tof_helpersto parse this information and extract detector geometry in the DIALS format.FormatMANDIis updated to use this by default.