Merged
Conversation
…riments - Set expert_level to 2. This matches the expert_level of the other geometry PHIL parameters - Bug fix: if the PHIL parameters are to do nothing, return the reference crystal model (if present) rather than None
aaronfinke
pushed a commit
to aaronfinke/dxtbx
that referenced
this pull request
Oct 7, 2025
* A couple of fixes for CrystalFactory.from_phil, for dials.modify_experiments - Set expert_level to 2. This matches the expert_level of the other geometry PHIL parameters - Bug fix: if the PHIL parameters are to do nothing, return the reference crystal model (if present) rather than None * news
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expert_levelto 2. This matches theexpert_levelof the other geometry PHIL parametersNone