Closed
Conversation
…t and return them as a Python list of strings
However, interestingly that shows that the history is wiped between each program. Why is that?
Member
Author
|
I might rethink this. The motif of making a new |
Member
Author
|
Superseded by #814 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds history tracking to
ExperimentList, such that every time an experiment list is written to disk, a history item is added containing the name of the module that calledas_file(oras_json) and a UTC timestamp.This is a step towards improved export of history to MTZ for dials/dials#2861.
Unfortunately it turns out that in DIALS we almost always create a new
ExperimentListand copy experiments into it rather than modifying the list loaded into a program, so the change here is not enough to preserve all history items. This PR will have to be followed by a DIALS PR that ensures history is also copied when we make newExperimentListobjects.