Conversation
Collaborator
Author
|
Now that 8ecaa44 has fixed these issues we should be able to reapply this |
aaronfinke
pushed a commit
to aaronfinke/dxtbx
that referenced
this pull request
Oct 7, 2025
Hatch/Hatchling (https://hatch.pypa.io/) Uses standard pyproject.toml [project] table settings, like setuptools, but provides more places for extensibility. That's used here to automatically generate the `dxtbx.format` and `console_scripts` entry-points on build. Opportunity take to do some more pyproject.toml consolidations. This patch originally had issues and was backed out because of DIALS using old packaging approaches. This was solved in 8ecaa44 so this should be safe to put back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hatch/Hatchling Uses standard pyproject.toml
[project]table settings, like setuptools, but provides more places for extensibility. That's used here to automatically generate thedxtbx.formatandconsole_scriptsentry-points on build. This also helps get rid of pip warnings that the previous way we were using setup.py is going to go away.Opportunity taken to do a little more pyproject.toml consolidation, and removing now-vestigial libtbx behaviour.
The first attempt (#766) caused
In hindsight, this might have been related to the other libtbx entry_point-breaking-behaviour that happened around the same time, which we now account for.
This should be investigated here before re-merging.