-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ribbons #1007
Merged
Merged
Ribbons #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as RNA, and to handle the broader range of potential names. Speeding up the protein and NA determination code by making the lists outside of the functions.
…ore information that is needed in the ribbon-printing code.
…ulating next/previous/duplicate information required for this processing.
…t so that a function can handle strings that hold integers as well.
…en multiple models are in a file.
cschlick
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Fixing the nucleic-acid residue code in Reduce to work with DNA as well as RNA, and to handle the broader range of potential names. Speeding up the protein and NA determination code by making the lists outside of the functions. * Adding scaffolding and initial functions for ribbon-generation code. * Documentation update * Adding function to produce the guidepoints for protein ribbons. * Continuing to implement ribbon generation, porting from the Java code. * Cleaning up command-line argument style and adding a choice for coloring for ribbons * Continuing to add ribbon support * Continuing to implement ribbon printing code. * Removing spurious Phil argument. Clarifying name of variable * Adding ability to set coil width * Updating the code dealing with secondary structure types to include more information that is needed in the ribbon-printing code. * Continuing to implement fancy-ribbon printing * Simplifying and correcting modulo calculation on chain colors. * Re-using existing method to determine chain colors based on index * Fixing indentation and initialization errors * Continuing to implement and debug ribbon code * Fixing rainbow color map to do once per chain. Fixing line thickness on ribbon edges. * Fixing element creation to get helix construction working better. * Integer division * Adding the triangle tip for the ribbon to the output * Removigtnn spurious parentheses * Adjusting the spline code to start and end at the correct control points * Added coil sections of ribbons and starting on sheets, including calculating next/previous/duplicate information required for this processing. * First version of ribbon code that generates helices, sheets, and coils. * Replacing SciPy NURBS with implementation of NRUBS ported from original Java code. * Replacing duplicate residue names with a single quote to reduce ribbon file sizes * Removing extra spaces at end of line. * Comment fix * Fixing multi-model behavior for ribbons. Casting parameter into an int so that a function can handle strings that hold integers as well. * Adding the ability to select atoms. Fixing the label on the models when multiple models are in a file. * Selecting only alternate a by default. Adding animation for multiple-model files we make ribbons for * Fixing print statement to be compatible with python 2 * Cleaning up clutter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a program to generate Kinemage ribbons from models.