Conversation
Collaborator
marjanfamili
commented
Feb 5, 2024
marjanfamili
commented
- changing the default value of visualisation flags to none, allows for either false or true to overwrite the vis_all
- removed my computer specific paths from notebook
- added more flexibility for appearance of the plots to plotting functions
… over writing setting.vis_* flags
…tes vis_all and give better control to the user, removed all path from personal pc from the notebook
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
crangelsmith
reviewed
Feb 5, 2024
| debug: bool = Field(False, description="Debug mode") | ||
| depth: PositiveInt = Field(3, description="Number of layers") | ||
| dynamic: bool = Field(False, description="Dynamic visualisation") | ||
| dynamic: Optional[bool] = Field(None, description="Dynamic visualisation") |
Collaborator
There was a problem hiding this comment.
This should be bool | None for 3.10 typing syntax, similar below.
crangelsmith
approved these changes
Feb 5, 2024
crangelsmith
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.