Merged
Conversation
jolaem
approved these changes
Nov 2, 2023
Collaborator
jolaem
left a comment
jolaem
left a comment
There was a problem hiding this comment.
Does the print actually affect the execution speed?
Collaborator
Author
I think makes it a bit slower because it has to write to disk in the log file. With a very big dataset that is a looot of prints per epoch. |
Collaborator
|
Ok cool, just tested this with 20k data points and it produced a 3 second difference per epoch which with 2000 epochs is well over an hour! |
Collaborator
Author
|
I'll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce logging to epoch level to accelerate run.
If we want to log at batch level, we can use the debug flag.