Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl functions #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

chrisjlee
Copy link

Add ability to use ssl Fixes #7 merging in changes done by @alexndreazevedo (Thanks btw)

add ability to use ssl
add usage example
update changes from ssl-forceserver
Update usage example
@chrisjlee
Copy link
Author

ping @ccoenraets

@ccoenraets
Copy link
Owner

@chrisjlee the server crashes at startup -- Looks like missing ). Also, what is the rationale for replacing the application/json content-type (as described in the doc: https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_usage_rest_resources.htm) with form-urlencoded?

@vdyalex
Copy link

vdyalex commented Oct 16, 2015

@ccoenraets the code was extended for a specific usage. I believe it's no longer able to be merged because the focus of your code is work within Heroku, but this one is to be used within own server. The Heroku usage wasn't tested. The Heroku SSL is managed by add-on, however the owned cloud server can be used with SSL directly into web server, the express in case.

Regarding the rationale replacement of content-type, when I tested it, SF worked only with form-urlencoded. Any request was failed when I used the application/json.

I'm glad with contribution of @chrisjlee, but the focus of ssl-forceserver was changed during the development with own server.

It works, as you can see: https://alexandreazevedo.me:8200/

Thank you, @ccoenraets and @chrisjlee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants