Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress github action config #4658

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Update cypress github action config #4658

merged 1 commit into from
Oct 7, 2022

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Oct 6, 2022

@nikolas nikolas force-pushed the cypress-fix branch 7 times, most recently from 7dd3eb0 to 6446a68 Compare October 6, 2022 21:58
These changes separate out the cypress run from the django tests.

* cypress-io/cypress#22086
* https://github.com/cypress-io/github-action
@nikolas
Copy link
Member Author

nikolas commented Oct 6, 2022

@ndittren I think this was a Firefox v105 issue, which would make sense why it just randomly started failing the other day. We didn't have the tests pinned to a specific Firefox release.

Switching back to Firefox 102.3.0esr causes the tests to run fine. The Firefox ESR releases should be a bit more stable than the main branch anyways.

The other changes in this PR break out the cypress tests to a separate github actions job from the django tests, which I think makes it a little more clear to us what's going wrong when things fail.

@ndittren ndittren merged commit 2697b94 into master Oct 7, 2022
@ndittren ndittren deleted the cypress-fix branch October 7, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants