[programmable-chat] Update react native to 0.40

[Maxwell2022]

Using the programmable-chat branch, alongside with react-native 0.40, I have few of errors building the project.

[Maxwell2022]

Can you try to reproduce it with:

- "react-native": "^0.40.0"
- "react-native-twilio-ip-messaging": "ccm-innovation/react-native-twilio-ip-messaging.git#programable-chat"
- cocoapod 1.2.0
- xcode 8.2.1
- macOS Sierra (10.12.2)

Here is my Podfile:

# Uncomment the next line to define a global platform for your project
# NOTE: The underlying Twilio SDKs require a minimum deployment target of 8.1
platform :ios, '8.1'

install! 'cocoapods', :deterministic_uuids => false

# List repo sources required
source 'https://github.com/CocoaPods/Specs.git'
source 'https://github.com/twilio/cocoapod-specs'

target 'reactnativeapp' do

  # Pods
  pod 'Fabric'
  pod 'Crashlytics'

  pod 'React', :path => '../node_modules/react-native'

  # Pods required for Twilio chat
  pod 'RCTTwilioChat', :path => '../node_modules/react-native-twilio-ip-messaging/ios'
  pod 'TwilioChatClient', '~> 0.16.0'
  pod 'TwilioAccessManager', '~> 0.1.1'
end

[Maxwell2022]

Somehow the build clean didn't remove the existing library libRTCTwilioIPMessaging, I deleted it manually, did another clean and build is now successful.

I still have few issues: Invalid data message But maybe the implementation slightly changed, I have to go through it

[Maxwell2022]

Just re-opening this issue because it's still related to react-native 0.40.0 and the programmable-chat branch

[Maxwell2022]

So it was implementation, not sure if you have a migration doc but it would be useful. Here is the issues I faced:

• Constant names changed from TWM... to TCH...
• new Client(token) is now waiting for a token as parameter instead of an accessManager
• Client needs to be registered against the accessManager after being initialised:

client.initialize().then(() => {
  accessManager.registerClient();
});

• getChannelByUniqueName becomes getChannel

I'm just wondering if we could abstract the access manager because we never use it directly. It might be a good idea building a factory that creates the accessManager and the Client, and return the client.

We are also looking into handling connection error for instance when the network connection drops, or when the websocket is failing for some reason. If you have any tips to handle this that'd be great!

[bradbyte]

@Maxwell2022 Yeah definitely need a migration doc.. hopefully that will be coming soon. I spent some time trying to envision the access manager role, namely, because Twilio no longer requires it. You can just initiate the client with a token now. So, while we are using access manager internally, I still want to preserve the SDK options in that it's not required. Thoughts?

[Maxwell2022]

I'm trying to abstract the AccessManager which I found redundant. What do you think of this:
Maxwell2022@3504073

[bradbyte]

Closing for now, added issue in new repo to use latest version of RN. Please open a new issue at https://github.com/ccm-innovation/react-native-twilio-chat with any new details.