Avoid deprecated ensure_package

[traylenator]

With puppetlabs-stdlib version 9:

juin 10 20:18:41 isaac puppet[23883]: Warning: This function is deprecated, please use stdlib::ensure_packages instead. at ["/etc/puppetlabs/code/environments/production/modules/mit_krb5/manifests/install.pp", 32]:["/etc/puppetlabs/code/environments/production/site.pp", 15]

[riton]

Hi @traylenator
Thanks for the contribution 👍

While I absolutely think we should tend toward the use of stdlib::ensure_packages, this will make this module incompatible with version 8.x of the puppetlabs-stdlib.
Version 9.x of puppetlabs-stdlib is still pretty new (May 30th 2023). We're not quite ready to drop support for those who are not yet ready to migrate to the latest puppetlabs-stdlib version. This include us at IN2P3-CC 😇

What about using something like:

$packages = $install.map |String $package_name| {
  {
    $package_name => {
      ensure => 'installed',
    }
  }
}

ensure_resources('package', $packages)

This would buy current module users some time to migrate their code to the latest puppetlabs-stdlib version while still allowing use with stdlib v9.x.

Thoughts ?

Regards

[jhoblitt]

@riton stdlib 8.x/9.x compatibility should be resolved by puppetlabs/puppetlabs-stdlib#1377

[jhoblitt]

This PR would supersede #34

[traylenator]

ensure_resources('package', $packages)

You can do just as

ensure_resources('packages', { 'ensure' => 'installed'})

rather than setting that up upfront.

For me nothing special needed, I am running a patched version this forever and can continue to do so. Only use this at home.