Skip to content

Update githooks.py NO_JIRA #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layfield-ccdc merged 4 commits into from
Feb 17, 2026
Merged

Update githooks.py NO_JIRA #30

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
281edb6
Update githooks.py NO_JIRA
layfield-ccdc Feb 17, 2026
51ad326
Update githooks.py NO_JIRA
layfield-ccdc Feb 17, 2026
e8d7adb
Update githooks.py NO_JIRA
layfield-ccdc Feb 17, 2026
ac031fc
Update githooks.py NO_JIRA
layfield-ccdc Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions main/githooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ def check_content(files):
return retval


def check_commit_msg(message, files, repo):
def check_commit_msg(message, files):
'''Check commit message (and file size).

Abort if file size exceeds hard (github.com) limit.
Expand All @@ -850,9 +850,9 @@ def check_commit_msg(message, files, repo):
# Not checking for JIRA or large file in commit message generated by github
return 0

if re.match(r'^ccdc-opensource', repo):
# Do not check for JIRA in opensource repo as we don't want to require external contributors to do this
return 0
# if re.match(r'^ccdc-opensource', repo):
# # Do not check for JIRA in opensource repo as we don't want to require external contributors to do this
# return 0

if NO_JIRA_MARKER not in message:
if jira_id_pattern.search(message) is None:
Expand Down Expand Up @@ -899,7 +899,7 @@ def _test(input, is_jira=True):
class TestCheckCommitMessage(unittest.TestCase):
def test_various_strings(self):
def _test(input, is_good=True):
rc = check_commit_msg(input, [], "dummy/repo")
rc = check_commit_msg(input, [])
self.assertEqual(rc == 0, is_good)
_test('ABC-1234')
_test('Some changes for ABC-1234 ticket')
Expand Down Expand Up @@ -944,6 +944,6 @@ def commit_msg_hook():
commit_message = Path(sys.argv[1]).read_text()

print(' Check commit message ...')
retval += check_commit_msg(commit_message, files['M'] + files['A'], get_repo())
retval += check_commit_msg(commit_message, files['M'] + files['A'])

return retval
return retval
Loading