-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update default sorting order to 'newest' in links component #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe default sorting order for links in the dashboard was updated from alphabetical ("az") to newest-first ("newest"). This change involves updating the initial value of the sorting variable in the main index component and adjusting the default prop value in the sorting component. No other logic or control flow was modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (7)**/components/**/*.{vue,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/coding-standards.mdc)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit Inference Engine (.cursor/rules/coding-standards.mdc)
Files:
**/*.{vue,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/coding-standards.mdc)
Files:
**/*.vue📄 CodeRabbit Inference Engine (.cursor/rules/component-patterns.mdc)
Files:
app/components/!(*ui)/**/*.vue📄 CodeRabbit Inference Engine (.cursor/rules/development-guidelines.mdc)
Files:
app/**/*📄 CodeRabbit Inference Engine (.cursor/rules/project-overview.mdc)
Files:
app/components/**/*.{vue,ts,js}📄 CodeRabbit Inference Engine (.cursor/rules/project-overview.mdc)
Files:
🧠 Learnings (2)📚 Learning: applies to **/*.vue : internal variables in components must use camelcase...
Applied to files:
📚 Learning: applies to **/*.{ts,tsx} : organize imports alphabetically...
Applied to files:
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This might trigger a bug, KV first page data completion. |
That’s interesting, are you sure this would affect KV first page completion? From my testing, switching the default sort to newest still loads the first page as expected. If there’s a specific scenario where it breaks, could you share details so I can verify and adjust accordingly? |
Change default link sorting to "newest first"
Summary
This PR changes the default sorting of links from alphabetical (A-Z) to newest first. This improves the user experience by showing the most recently created links at the top of the list.
Why this change is beneficial
Changes
sortBy
value inapp/components/dashboard/links/Index.vue
from 'az' to 'newest'Testing
Summary by CodeRabbit