Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and default run_id for 2025 #352

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

dfsnow
Copy link
Member

@dfsnow dfsnow commented Feb 20, 2025

This PR makes minor updates to the README for tax year 2025.

@dfsnow dfsnow changed the title Update README for 2025 Update README and default run_id for 2025 Feb 20, 2025
Comment on lines -401 to -402
| PUMA Housing Index | [DePaul Institute for Housing Studies](https://www.housingstudies.org/) |
| School Ratings | [GreatSchools.org](https://greatschools.org/), aggregated to the district level |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dropped from the model, so I figured it would be confusing to keep them in this table. They are still present in the training/assessment data however.

@@ -498,7 +496,7 @@ There a few caveats with this approach and with balance testing in general:

In addition to the first-pass modeling done by LightGBM, the CCAO also performs a set of simple adjustments on the initial predicted values from the `assess` stage. These adjustments are internally called "post-modeling," and are responsible for correcting minor deficiencies in the initial predictions. Specifically, post-modeling will:

1. Aggregate values for multi-card properties to the PIN level, then disaggregate them back to the card level. A check is used to ensure that the PIN-level assessed value is not significantly greater than the prior year's value. This is needed because often back buildings (ADUs, secondary buildings) will receive a much higher initial value than they are actually worth (since they are not differentiated as ADUs by the model).
1. Handle multi-card properties. For PINs with more than 3 cards, this means summing the estimate for each card to the PIN level, then disaggregating back to the card level. For PINs with 3 or fewer cards, the initial prediction of the _largest_ card (plus the building square footage of the remaining cards) is used as the PIN-level estimate.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates for the new multi-card handling introduced by #328.

@@ -591,9 +597,9 @@ The property characteristics we track can sometimes be incorrect or outdated. Th

These errors can cause under- *or* over-assessment. If you believe your property has been misvalued due to a characteristic error or the property characteristics recorded on our website are incorrect. Please [contact our office](https://www.cookcountyassessor.com/contact) to file a property characteristic appeal.

##### Non-Arms-Length Sales
##### Non-Arms-Length/Non-Market Sales
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating language per the commercial folks suggestions from awhile back.

@@ -15,7 +15,7 @@ format:
fig-align: center
fontsize: 12pt
params:
run_id: "2025-01-13-dazzling-kyra"
run_id: "2025-02-11-charming-eric"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here just setting the default run ID to the final model for the year.

@dfsnow dfsnow marked this pull request as ready for review February 20, 2025 19:16
@dfsnow dfsnow mentioned this pull request Feb 20, 2025
8 tasks
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this chore! One quick question: Do we also want to update the top-level Prior Models table in the README to include a link to 2025? Not sure whether that table should include the most recent assessment year or not, I'll defer to whatever you think is best.

@dfsnow
Copy link
Member Author

dfsnow commented Feb 20, 2025

In the past we have not included the current model/most recent assessment in that table. I think it's fine as-is.

@dfsnow dfsnow merged commit b437bc7 into 2025-assessment-year Feb 20, 2025
4 checks passed
@dfsnow dfsnow deleted the dfsnow/tidy-2025 branch February 20, 2025 19:30
dfsnow added a commit that referenced this pull request Feb 25, 2025
* Update default run IDs

* Add 2025 data links

* Add 2025 changelog

* Update README for 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants