Simplify new multi-card method #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
changed the base branch from
2025-assessment-year
to
try-additive-multi-card-solution
dfsnow
force-pushed
the
dfsnow/simplify-new-mc-method
branch
from
1ae4f1a to
4536176
Compare
| )$.pred, | ||
| char_bldg_sf = og_char_bldg_sf | ||
| ) %>% | ||
| select(-og_char_bldg_sf) |
There was a problem hiding this comment.
Really nice cleanup here
|
Looks good to me |
wagnerlmichael
merged commit 9c47e1b
into
try-additive-multi-card-solution
4 checks passed
dfsnow
added a commit
that referenced
this pull request
Jan 28, 2025
…#328) * Add some additive solutions and checks for single card values * Remove other methods * Clean up multi-card edit and replace paths * Remove spaces * De-aggregate card preds * Format * Shorten ariable name * Format variable name length * Format variable name length * Add space back * Remove strings * Add back group by * Add multi-card analysis for challenge groups * Format * Format * Clean up comment * Fix pin aggregation * Switch strategy between 2-3 cards and 4+ cards * Lint * Fix decile calculation * Simplify new multi-card method (#335) * Revert MC data munging * Simplify multi-card handling code --------- Co-authored-by: Dan Snow <dan@sno.ws> Co-authored-by: Dan Snow <31494343+dfsnow@users.noreply.github.com>
dfsnow
added a commit
that referenced
this pull request
Feb 25, 2025
…#328) * Add some additive solutions and checks for single card values * Remove other methods * Clean up multi-card edit and replace paths * Remove spaces * De-aggregate card preds * Format * Shorten ariable name * Format variable name length * Format variable name length * Add space back * Remove strings * Add back group by * Add multi-card analysis for challenge groups * Format * Format * Clean up comment * Fix pin aggregation * Switch strategy between 2-3 cards and 4+ cards * Lint * Fix decile calculation * Simplify new multi-card method (#335) * Revert MC data munging * Simplify multi-card handling code --------- Co-authored-by: Dan Snow <dan@sno.ws> Co-authored-by: Dan Snow <31494343+dfsnow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wagnerlmichael