Skip to content

Make onHighlight() add to an array of callbacks rather than overwriting previous #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yozlet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make onHighlight() add to an array of callbacks rather than overwriting previous #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd78c4a
onHighlight() adds to an array of callbacks rather than overwriting p…
yozlet Jun 24, 2013
c7430c9
Fix for-loop variable collision
yozlet Jun 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions js/rainbow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ window['Rainbow'] = (function() {
global_class,

/**
* @type {null|Function}
* @type {Array}
*/
onHighlight;
onHighlight = [];

/**
* cross browser get attribute for an element
Expand Down Expand Up @@ -631,8 +631,9 @@ window['Rainbow'] = (function() {
replacement_positions = {};

// if you have a listener attached tell it that this block is now highlighted
if (onHighlight) {
onHighlight(block, language);
if (onHighlight.length > 0) {
for(ohn=0; ohn<onHighlight.length; ohn++)
onHighlight[ohn](block, language);
}

// process the next block
Expand Down Expand Up @@ -739,7 +740,7 @@ window['Rainbow'] = (function() {
* @param {Function} callback
*/
onHighlight: function(callback) {
onHighlight = callback;
onHighlight.push(callback);
},

/**
Expand Down
26 changes: 26 additions & 0 deletions tests/api.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,31 @@ <h1>API Test Page</h1>
$("#stuff").append('<p>got callback<p>');
});
}, 1000);

// Set an onHighlight() callback
setTimeout(function() {
Rainbow.onHighlight(function(){
$("#stuff").append('<p>Got onHighlight() callback</p>')
});

$("#stuff").append('<p>code inserted dynamically with callback:</p><pre><code data-language="javascript">var html = $("#stuff").html();</code></pre>');
Rainbow.color();
}, 1250);

// Set multiple onHighlight() callbacks
setTimeout(function() {
Rainbow.onHighlight(function(){
window._OHTest = 1;
});

Rainbow.onHighlight(function(){
window._OHTest++;
$("#stuff").append('<p>This number should be 2: <b>'
+ window._OHTest + '</b></p>');
});

$("#stuff").append('<p>code inserted dynamically with callback:</p><pre><code data-language="javascript">var html = $("#stuff").html();</code></pre>');
Rainbow.color();
}, 1500);
</script>
</body>