No update registries?

[SirEdvin]

Minecraft Version

1.21.x

Version

1.115.1

Details

My code usually heavy really on using upgrade id and their registries, but it seems now that they are not working anymore?

I get java.lang.IllegalArgumentException: Cannot find registry ResourceKey[minecraft:root / computercraft:pocket_upgrade] or same for turtle upgrade when I am trying to accessing it.

[SquidDev]

I haven't seen the rest of your code, but I suspect you're looking up upgrades in the root registry? Upgrades are loaded into dynamic registries, so you need to go through the server's HolderLookup.Provider instead (e.g. level.registryAccess().lookupOrThrow(IPocketUpgrade.REGISTRY)).

My code usually heavy really on using upgrade id

Don't do that! Instead, you want to be reading upgrades through a codec instead (either PocketUpgrades.instance().upgradeCode() or upgradeDataCodec()). Yes, it's lot of code to rewrite, but trust me it looks nicer in the end!

[SirEdvin]

I have slightly related problem and also what to ask for question here again.

I am using registry lookups and uses it in when I am trying to fill my creative tab:

ModPlatform.holder.turtleUpgrades.forEach {
            val upgrade = ComputerPlatformRegistries.TURTLE_UPGRADES.getAnyHolder(it.id)
            if (upgrade.isPresent) {
                output.accept(DataComponentUtil.createStack(ModRegistry.Items.TURTLE_ADVANCED.get(), ModRegistry.DataComponents.RIGHT_TURTLE_UPGRADE.get(), UpgradeData.ofDefault(upgrade.get())))
                output.accept(DataComponentUtil.createStack(ModRegistry.Items.TURTLE_NORMAL.get(), ModRegistry.DataComponents.RIGHT_TURTLE_UPGRADE.get(), UpgradeData.ofDefault(upgrade.get())))
            }
        }

getAnyHolder iterates over all records in registry and returns me holder with specific id. Everything fine, turtle registered, but when I am trying to take turtle from creative tab, I get this error:

Caused by: java.lang.IllegalArgumentException: Can't find id for 'Reference{ResourceKey[computercraft:turtle_upgrade / peripheralworks:peripheralium_hub]=site.siredvin.peripheralworks.computercraft.turtles.PeripheraliumHubTurtleUpgrade@7d6d4aab}' in map net.minecraft.core.Registry$1@34760460

What I am doing wrong?

[SirEdvin]

Aside from this upgrades working just fine

[SquidDev]

From what I can tell looking through the code, ComputerPlatformRegistries.TURTLE_UPGRADES is a (cached) version of the current server's registries? Ahh! That's best avoided — it's not really safe, as the registries may change across worlds/reloads.

The available registries are pretty much always passed around as arguments. For creative tags, the context parameter to displayItems has what you want:

       .displayItems { context, output ->
            ModPlatformt.holder.blocks.forEach { output.accept(it.get()) }
            ModPlatform.holder.items.forEach { output.accept(it.get()) }
            PeripheralWorksCommonHooks.registerUpgradesInCreativeTab(output, context.holders())
            // ^ context.holders() will be your HolderLookup.Provider
        }

As an aside, you probably can drop a lot of the registry multi-loader abstractions on 1.21. Aside from registration (which does still go through events), NeoForge does pretty much just use vanilla code.

[SquidDev]

If it's helpful, CC:T just loops through the whole registry and finds matching upgrades, rather than maintaining its own list of upgrades. It's a little easier (and works better with datapacks), though I guess doesn't maintain a consistent order.

CC-Tweaked/projects/common/src/main/java/dan200/computercraft/shared/ModRegistry.java

Lines 698 to 704 in 08dc08b

	private static void addTurtle(CreativeModeTab.Output out, TurtleItem turtle, HolderLookup.Provider registries) {
	out.accept(new ItemStack(turtle));
	registries.lookupOrThrow(ITurtleUpgrade.REGISTRY).listElements()
	.filter(ModRegistry::isOurUpgrade)
	.map(x -> DataComponentUtil.createStack(turtle, DataComponents.RIGHT_TURTLE_UPGRADE.get(), UpgradeData.ofDefault(x)))
	.forEach(out::accept);
	}

[SirEdvin]

Thanks for your help again!
Everything works and also data components working just fine!