Jrb improvements 2 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2018 11:50
Mark all internal functions as static and use 'void' for functions that take no parameters. Allows us to build cleanly with stricter warnings on GCC (-Wmissing-prototypes -Wstrict-prototypes).
- Check the return value from write() for the one/two byte write case (-y/-z) and report any errors. - Use perror for reporting failures that set errno. - Print all fatal errors to stderr. - Don't report EAGAIN errors from write(). These are expected since we are using non-blocking I/O. - Missing port argument now exits with a code of 1 rather than 0. - Clamp the exit code to a maximum of 125 to avoid clashes with standard shell exit codes.
Use long long ints for the counter variables so that they won't wrap when running a long soak test.
Previously a message would be printed every second if no data was being received. This commit improves things so that it prints messages for both transmission and reception timing out, and tells you how long it has been since data was last received/transmitted. The initial timeout for both transmission and reception is now two seconds, and after that messages are printed every second.
This adds a new option to have the output bytes range from 32 to 126 instead of the default 0 to 255. There are two reasons why this is useful, one is that you can directly output the bytes at the receiving end without getting any unprintable codes, and the other is that the sequence is not a power of two in length, which would reveal problems where a faulty serial driver dropped a complete buffer of data (e.g. 256 bytes or 1024 bytes) that would get missed using the default sequence.
|
Looks good -- thanks for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a miscellaneous set of improvements I did when debugging a serial problem recently. They aren't really related to each other so I can split these up into multiple pull requests if you would prefer.