Fix: Correct PDF Export Settings Not Applying (Issue #1954) #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes Issue #1954, where the PDF export did not apply custom settings such as tile spacing, grid layout, margins, and tile sizing.
The problem was that values from the UI (pdfSettings) were not being passed correctly to pdfExportAdapter.
Fix Implemented
Correctly mapped pdfSettings values to pdfExportAdapter().
Added fallback defaults to prevent undefined values.
Ensured all PDF configuration options are included:
tileSize
tileSpacing
gridColumns
gridRows
pageMargin
Cleaned up the helper block managing fonts and export config.
Testing
Verified PDF export now reflects UI settings.
Tested with multiple boards and tile counts.
Confirmed no regression with Picsee PDF exporter.
Related Issue
Fixes #1954.