Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 유저 정보 관련 API #21

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Feat: 유저 정보 관련 API #21

wants to merge 4 commits into from

Conversation

eunseobb
Copy link
Collaborator

@eunseobb eunseobb commented Oct 5, 2023

No description provided.

@mk3058 mk3058 linked an issue Oct 7, 2023 that may be closed by this pull request
@ckyeon ckyeon self-requested a review October 9, 2023 07:40
@eunseobb eunseobb self-assigned this Oct 12, 2023
@eunseobb eunseobb requested a review from ckyeon October 21, 2023 04:36
Copy link
Member

@ckyeon ckyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 잘 짜주셨네요~~ 👍👍

public void initializeProfile(Long userId, InitializeRequest initializeRequest){


User user = userRepository.findById(userId).orElseThrow(() -> new IllegalArgumentException("not found : " + userId));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findById().orElseThrow() 사이에 줄바꿈을 넣어주시면 더욱 가독성 좋은 코드가 될 것 같습니다!

User user = userRepository.findById(userId)
    .orElseThrow(() -> new IllegalArgumentException("not found : " + userId));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

유저 정보 관련 API 추가
2 participants