Create default entities - mk3058 #14

mk3058 · 2023-08-22T03:44:09Z

올려주신 pr 참고해서 기본 엔티티를 추가했습니다.

ckyeon

중복되는 부분 몇 개는 리뷰를 추가하지 않았습니다!
리뷰가 없더라도 다른 리뷰를 토대로 수정해보시면 좋을 것 같아요~~

ckyeon · 2023-08-22T05:10:51Z

src/main/java/com/sequence/anonymous/college/domain/College.java

+    this.location = location;
+  }
+
+  public void updateName(CollegeUpdateDto dto) {


domain layer는 presentation layer에 속한 dto에 의존하지 않는 것이 좋습니다!

아래의 아티클을 확인해보시면 좋을 것 같습니다.
https://techblog.woowahan.com/2647

ckyeon · 2023-08-22T05:14:11Z

src/main/java/com/sequence/anonymous/college/domain/Department.java

+    this.college = college;
+  }
+
+  public void updateName(DepartmentUpdateDto dto) {


domain layer는 presentation layer에 속한 dto에 의존하지 않는 것이 좋습니다!

ckyeon · 2023-08-22T05:20:27Z

src/main/java/com/sequence/anonymous/invite/domain/Invite.java

+  private Invite(User inviter, User invitee, InviteKind kind, InviteStatus status) {
+    Preconditions.checkArgument(inviter != null, "inviter must be provided");
+    Preconditions.checkArgument(invitee != null, "invitee must be provided");
+    Preconditions.checkArgument(kind != null, "kind must be provided");
+


status에 대한 검증 로직도 추가해주시면 좋을 것 같습니다~

ckyeon · 2023-08-22T05:45:43Z

src/main/java/com/sequence/anonymous/college/domain/presentation/dto/CollegeUpdateDto.java

+import org.springframework.data.geo.Point;
+
+@Getter
+public class CollegeUpdateDto {


RequestDto는 유저의 request body를 매핑하는 용도로만 사용하기 때문에 다른 클래스에서 접근이 불가능하도록 public 생성자가 아닌 protected 생성자를 임의로 만들어주는 것이 좋습니다!

ckyeon · 2023-08-22T05:45:58Z

src/main/java/com/sequence/anonymous/college/domain/presentation/dto/DepartmentUpdateDto.java

+import lombok.Getter;
+
+@Getter
+public class DepartmentUpdateDto {


RequestDto는 유저의 request body를 매핑하는 용도로만 사용하기 때문에 다른 클래스에서 접근이 불가능하도록 public 생성자가 아닌 protected 생성자를 임의로 만들어주는 것이 좋습니다!

ckyeon · 2023-08-22T05:46:50Z

src/main/java/com/sequence/anonymous/college/domain/presentation/dto/CollegeUpdateDto.java

@@ -0,0 +1,12 @@
+package com.sequence.anonymous.college.domain.presentation.dto;


presentation 패키지의 위치가 잘못된 것 같습니다!

ckyeon · 2023-08-22T05:47:54Z

src/main/java/com/sequence/anonymous/matchPost/domain/MatchPost.java

+  @Column(nullable = false)
+  private String title;
+
+  @Column(columnDefinition = "TEXT", nullable = false)
+  private String introduce;
+
+  private String appeal;
+
+  @Enumerated(EnumType.STRING)
+  private MatchPostStatus status;


@Column(length= <number>)를 통해 각 컬럼의 길이를 지정해주면 좋을 것 같습니다!

ckyeon · 2023-08-22T05:48:17Z

src/main/java/com/sequence/anonymous/matchPost/domain/MatchPost.java

+  public void updateMatchPost(MatchPostUpdateDto dto) {
+    this.title = dto.getTitle();
+    this.introduce = dto.getIntroduce();
+    this.appeal = dto.getAppeal();
+    this.status = dto.getStatus();
+  }


domain layer는 presentation layer에 속한 dto에 의존하지 않는 것이 좋습니다!

src/main/java/com/sequence/anonymous/matchPost/domain/MatchPost.java

ckyeon · 2023-08-22T05:49:32Z

src/main/java/com/sequence/anonymous/matchPost/presentation/dto/MatchPostUpdateDto.java

+public class MatchPostUpdateDto {
+
+  private String title;
+
+  private String introduce;
+
+  private String appeal;
+
+  private MatchPostStatus status;
+}


RequestDto는 유저의 request body를 매핑하는 용도로만 사용하기 때문에 다른 클래스에서 접근이 불가능하도록 public 생성자가 아닌 protected 생성자를 임의로 만들어주는 것이 좋습니다!

src/main/java/com/sequence/anonymous/user/domain/User.java

ckyeon · 2023-08-26T07:31:11Z

src/main/java/com/sequence/anonymous/user/domain/User.java

+    Preconditions.checkArgument(gender != null, "gender must be provided.");
+    Preconditions.checkArgument(college != null, "college must be provided.");
+    Preconditions.checkArgument(department != null, "department must be provided.");
+    Preconditions.checkArgument(age >= 20, "age must be at least 20");


나이가 3~40 이상인 경우도 체크할 수 있을 것 같습니다!

ckyeon · 2023-08-26T07:33:55Z

src/main/java/com/sequence/anonymous/college/presentation/dto/UpdateDto.java

+import org.springframework.data.geo.Point;
+
+@Getter
+public class UpdateDto {


해당 DTO가 서버에 요청되는 Request인지 응답에 이용되는 Response인지 구분할 수 있게 네이밍되면 좋을 것 같습니다!

ex) UpdateRequest, UpdateResponse

ckyeon · 2023-09-04T09:29:45Z

src/main/java/com/sequence/anonymous/user/presentation/UserMatchPostController.java

+package com.sequence.anonymous.user.presentation;
+
+import com.sequence.anonymous.user.application.UserMatchPostService;
+import lombok.RequiredArgsConstructor;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+@RequiredArgsConstructor
+@RequestMapping("/user-match-posts")
+public class UserMatchPostController {
+  private final UserMatchPostService userMatchPostService;
+}


UserMatchPost, UserTag와 같이 ManyToMany를 풀어내기 위한 클래스들은 Controller나 Service가 필요없는 경우가 많습니다!

그러므로 나중에 구현하다 필요하실 때 만들어주시면 좋을 것 같습니다~

ckyeon · 2023-09-04T09:29:52Z

src/main/java/com/sequence/anonymous/user/presentation/UserTagController.java

+package com.sequence.anonymous.user.presentation;
+
+import com.sequence.anonymous.user.application.UserTagService;
+import lombok.RequiredArgsConstructor;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+@RequiredArgsConstructor
+@RequestMapping("/user-tags")
+public class UserTagController {
+  private final UserTagService userTagService;
+}


UserMatchPost, UserTag와 같이 ManyToMany를 풀어내기 위한 클래스들은 Controller나 Service가 필요없는 경우가 많습니다!

그러므로 나중에 구현하다 필요하실 때 만들어주시면 좋을 것 같습니다~

ckyeon · 2023-09-04T09:30:04Z

src/main/java/com/sequence/anonymous/user/presentation/UserChatController.java

+package com.sequence.anonymous.user.presentation;
+
+import com.sequence.anonymous.user.application.UserChatService;
+import lombok.RequiredArgsConstructor;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+@RequiredArgsConstructor
+@RequestMapping("/user-chats")
+public class UserChatController {
+  private final UserChatService userChatService;
+}


UserMatchPost, UserTag와 같이 ManyToMany를 풀어내기 위한 클래스들은 Controller나 Service가 필요없는 경우가 많습니다!

그러므로 나중에 구현하다 필요하실 때 만들어주시면 좋을 것 같습니다~

ckyeon · 2023-09-04T09:30:47Z

src/main/java/com/sequence/anonymous/user/presentation/AttachmentController.java

+package com.sequence.anonymous.user.presentation;
+
+import com.sequence.anonymous.user.application.AttachmentService;
+import com.sequence.anonymous.user.domain.repository.AttachmentRepository;
+import lombok.RequiredArgsConstructor;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+@RequiredArgsConstructor
+@RequestMapping("/attachments")
+public class AttachmentController {
+  private final AttachmentService attachmentService;
+}


Attachment는 엔드포인트가 필요없을 것 같습니다!
(MatchPost나 User에 종속되기 때문) (독립적으로 존재 x)

ckyeon · 2023-09-04T09:34:30Z

src/main/java/com/sequence/anonymous/college/domain/College.java

+  @Column(length = 20, nullable = false, unique = true)
+  private String name;
+
+  private Point location;


Point와 같은 Value Object를 사용하시려면 사용하는 엔티티 프로퍼티에 @Embedded를 달아주시고,
Point 클래스에 @Embeddable을 달아주셔야 합니다.

mk3058 added 2 commits August 22, 2023 00:46

feat(domain): college, invite, user, relation, tag, attachment 관련 엔티티 추가

a280750

feat(domain): add default entities

c65be37

mk3058 added the feat label Aug 22, 2023

mk3058 requested a review from ckyeon August 22, 2023 03:44

mk3058 self-assigned this Aug 22, 2023

mk3058 linked an issue Aug 22, 2023 that may be closed by this pull request

Create default entities #12

Closed

ckyeon reviewed Aug 22, 2023

View reviewed changes

mk3058 added 4 commits August 23, 2023 11:15

refactor: 일부 잘못된 패키지 경로 수정. 패키지/클래스 이름 수정

45b31eb

refactor(entity): 문자열 컬럼 길이 지정, 일부 생성자 값 검즘 추가

ffc3874

refactor(dto): Request Dto protected 생성자 추가

3b13bba

refactor: domain계층이 presentation계층에 의존하지 않도록 수정

deb1214

mk3058 requested a review from ckyeon August 26, 2023 03:58

ckyeon reviewed Aug 26, 2023

View reviewed changes

mk3058 added 5 commits August 27, 2023 12:21

fix(user): 유저의 나이가 20-30 범위로 제한되도록 수정

a241e1a

refactor(dto): dto 이름 수정

b650a6e

fix(User): 참조 타입에 대한 값 검증 추가

da54071

refactor(matchpost): 패키지 이름 수정

34ce3d8

fix(User): 나이 검증 조건 수정

37bfa4e

mk3058 requested a review from ckyeon August 27, 2023 04:09

mk3058 added 8 commits September 4, 2023 12:57

feat(chat): 기본 클래스 추가

65fdd5c

feat(college): 기본 클래스 추가

5746534

feat(invite): 기본 클래스 추가

6205617

feat(matchPost): 기본 클래스 추가

2a734f1

feat(relation): 기본 클래스 추가

2e41c43

fix(matchPost): MatchServicePost 클래스를 순환 참조하던 문제 수정

26a257c

feat(tag): 기본 클래스 추가

426437b

feat(user): 기본 클래스 추가

bffdf80

ckyeon requested changes Sep 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create default entities - mk3058 #14

Create default entities - mk3058 #14

mk3058 commented Aug 22, 2023

ckyeon left a comment

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 22, 2023

ckyeon Aug 26, 2023

ckyeon Aug 26, 2023

ckyeon Sep 4, 2023

ckyeon Sep 4, 2023

ckyeon Sep 4, 2023

ckyeon Sep 4, 2023

ckyeon Sep 4, 2023

		@@ -0,0 +1,12 @@
		package com.sequence.anonymous.college.domain.presentation.dto;

Create default entities - mk3058 #14

Are you sure you want to change the base?

Create default entities - mk3058 #14

Conversation

mk3058 commented Aug 22, 2023

ckyeon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment