Skip to content

Conversation

armin-reichert
Copy link

Unit test caused warnings in IDE because it tested a deprecated method. Order of assertEquals() arguments was wrong which also caused warnings.

…er of arguments in assertEquals() (caused no harm but warnings too).
@mkarg
Copy link
Collaborator

mkarg commented Aug 31, 2025

Test test must stay as long as the method exists, as the method must work while it exists.

The test will get remove once the method was removed.

@armin-reichert
Copy link
Author

Mag sein. Es ist halt so, dass nach dem Fork des Repository dieser Test als Einziger in meiner IDE (IntelliJ) einen Fehler verursacht hat.
Gruß Armin

@mkarg
Copy link
Collaborator

mkarg commented Sep 1, 2025

A warning is not a fail. If you IDEA fails, you might be able to reconfigure it to accept warnings.

While some of us speak German, please generally comment in English. Most contributors (and users) do not speak German. Thanks.

@armin-reichert
Copy link
Author

Dann lass es halt. The just let it.

@mkarg
Copy link
Collaborator

mkarg commented Sep 1, 2025

I actually do neither understand your aggressive tone nor your closing of the issue. You change was correct and accepted. All what I wanted to tell you is that merging it has to wait until the deprecated method is removed - which is planned for near future.

@mkarg mkarg reopened this Sep 1, 2025
@armin-reichert
Copy link
Author

armin-reichert commented Sep 1, 2025

Lieber Markus,
ich habe eine lange Karriere in der Softwarebranche hinter mir. Ich benötige keine Belehrungen von wegen "aggressivem Ton" etc. Ich weiß, womit ich es hier zu tun habe und damit ist es für mich auch gut.

@mkarg
Copy link
Collaborator

mkarg commented Sep 2, 2025

Reopening as we plan to integrate later.

@mkarg mkarg reopened this Sep 2, 2025
@mkarg mkarg force-pushed the master branch 2 times, most recently from 4dbceb5 to a1d8505 Compare October 5, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants