Skip to content

Feature/vign edits#269

Merged
eoduniyi merged 2 commits into
developfrom
feature/vign-edits
Aug 20, 2020
Merged

Feature/vign edits#269
eoduniyi merged 2 commits into
developfrom
feature/vign-edits

Conversation

@eoduniyi
Copy link
Copy Markdown
Collaborator

@eoduniyi eoduniyi commented Aug 20, 2020

Summary:

I revised the remaining portions of the fileio.Rmd vignette. Overall, it is a beautiful document.
Super technical.

I did my best to make it more formal:

  • removing personal pronouns
  • reducing wordiness
  • correcting misspellings

And when it was clear:

  • punctuation
  • syntax
  • semantics

And whatever else my introductory linguistics book taught me.

@GegznaV I'm not sure what the rule is for spacing between titles (headers), code blocks, comments, etc.
@eoduniyi eoduniyi added Type: enhancement 🎈 asking for a new feature. Topic: documentation 📘 Related to hyperSpec's (non-vignette) documentation. Use a separate dag for vignettes. labels Aug 20, 2020
@eoduniyi eoduniyi requested a review from GegznaV August 20, 2020 10:52
@eoduniyi eoduniyi added the Topic: vignette 📗 Related to vignettes of hyperSpec label Aug 20, 2020
@eoduniyi eoduniyi merged commit 15c39a3 into develop Aug 20, 2020
@eoduniyi eoduniyi deleted the feature/vign-edits branch August 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Topic: documentation 📘 Related to hyperSpec's (non-vignette) documentation. Use a separate dag for vignettes. Topic: vignette 📗 Related to vignettes of hyperSpec Type: enhancement 🎈 asking for a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant