Add ui::PropertyChangeReason argument to aura::WindowObserver methods.

With this CL, aura::WindowObserver::OnWindow(Bounds|Opacity)Changed() have a new argument that indicates whether the property was set directly or by an animation. The goal is to allow the upcoming aura::WindowOcclusionTracker to know when animations start without calling ui::LayerAnimator::IsAnimatingOnePropertyOf(). TBR=sky@chromium.org Bug: 738387 Change-Id: I91634a61f3abe99bb2240d4039c9f9fc5affbc65 Reviewed-on: https://chromium-review.googlesource.com/753706 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515729}
cbchan · Nov 10, 2017 · f935b87 · f935b87
1 parent ed3d368
commit f935b87
Show file tree

Hide file tree

Showing 56 changed files with 262 additions and 80 deletions.
diff --git a/ash/display/window_tree_host_manager_unittest.cc b/ash/display/window_tree_host_manager_unittest.cc
@@ -1489,7 +1489,8 @@ class RootWindowTestObserver : public aura::WindowObserver {
 
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     shelf_display_bounds_ = ScreenUtil::GetDisplayBoundsWithShelf(window);
   }
 

diff --git a/ash/magnifier/magnification_controller.cc b/ash/magnifier/magnification_controller.cc
@@ -140,7 +140,8 @@ class MagnificationControllerImpl : public MagnificationController,
   void OnWindowDestroying(aura::Window* root_window) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // Redraws the magnification window with the given origin position and the
   // given scale. Returns true if the window is changed; otherwise, false.
@@ -566,7 +567,8 @@ void MagnificationControllerImpl::OnWindowDestroying(
 void MagnificationControllerImpl::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   // TODO(yoshiki): implement here. crbug.com/230979
 }
 

diff --git a/ash/wallpaper/wallpaper_widget_controller.cc b/ash/wallpaper/wallpaper_widget_controller.cc
@@ -108,7 +108,8 @@ void WallpaperWidgetController::RemoveObservers() {
 void WallpaperWidgetController::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   SetBounds(new_bounds);
 }
 

diff --git a/ash/wallpaper/wallpaper_widget_controller.h b/ash/wallpaper/wallpaper_widget_controller.h
@@ -53,7 +53,8 @@ class ASH_EXPORT WallpaperWidgetController : public views::WidgetObserver,
   // aura::WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   views::Widget* widget_;
 

diff --git a/ash/wm/lock_layout_manager.cc b/ash/wm/lock_layout_manager.cc
@@ -77,7 +77,8 @@ void LockLayoutManager::OnWindowDestroying(aura::Window* window) {
 
 void LockLayoutManager::OnWindowBoundsChanged(aura::Window* window,
                                               const gfx::Rect& old_bounds,
-                                              const gfx::Rect& new_bounds) {
+                                              const gfx::Rect& new_bounds,
+                                              ui::PropertyChangeReason reason) {
   if (root_window_ == window) {
     const wm::WMEvent wm_event(wm::WM_EVENT_DISPLAY_BOUNDS_CHANGED);
     AdjustWindowsForWorkAreaChange(&wm_event);

diff --git a/ash/wm/lock_layout_manager.h b/ash/wm/lock_layout_manager.h
@@ -60,7 +60,8 @@ class ASH_EXPORT LockLayoutManager
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // ShellObserver:
   void OnVirtualKeyboardStateChanged(bool activated,

diff --git a/ash/wm/overview/window_grid.cc b/ash/wm/overview/window_grid.cc
@@ -597,7 +597,8 @@ void WindowGrid::OnWindowDestroying(aura::Window* window) {
 
 void WindowGrid::OnWindowBoundsChanged(aura::Window* window,
                                        const gfx::Rect& old_bounds,
-                                       const gfx::Rect& new_bounds) {
+                                       const gfx::Rect& new_bounds,
+                                       ui::PropertyChangeReason reason) {
   // During preparation, window bounds can change. Ignore bounds
   // change notifications in this case; we'll reposition soon.
   if (!prepared_for_overview_)

diff --git a/ash/wm/overview/window_grid.h b/ash/wm/overview/window_grid.h
@@ -140,7 +140,8 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver,
   // TODO(flackr): Handle window bounds changed in WindowSelectorItem.
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // wm::WindowStateObserver:
   void OnPostWindowStateTypeChange(wm::WindowState* window_state,

diff --git a/ash/wm/resize_shadow.cc b/ash/wm/resize_shadow.cc
@@ -100,7 +100,8 @@ ResizeShadow::~ResizeShadow() {
 
 void ResizeShadow::OnWindowBoundsChanged(aura::Window* window,
                                          const gfx::Rect& old_bounds,
-                                         const gfx::Rect& new_bounds) {
+                                         const gfx::Rect& new_bounds,
+                                         ui::PropertyChangeReason reason) {
   UpdateBoundsAndVisibility();
 }
 

diff --git a/ash/wm/resize_shadow.h b/ash/wm/resize_shadow.h
@@ -30,7 +30,8 @@ class ResizeShadow : public aura::WindowObserver {
   // aura::WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowHierarchyChanged(const HierarchyChangeParams& params) override;
   void OnWindowStackingChanged(aura::Window* window) override;
 

diff --git a/ash/wm/root_window_layout_manager_unittest.cc b/ash/wm/root_window_layout_manager_unittest.cc
@@ -18,7 +18,8 @@ class WindowDeleter : public aura::WindowObserver {
   // aura::WindowObserver::
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     delete target_;
   }
 

diff --git a/ash/wm/system_wallpaper_controller.cc b/ash/wm/system_wallpaper_controller.cc
@@ -33,7 +33,8 @@ void SystemWallpaperController::SetColor(SkColor color) {
 void SystemWallpaperController::OnWindowBoundsChanged(
     aura::Window* root,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   DCHECK_EQ(root_window_, root);
   layer_->SetBounds(gfx::Rect(root_window_->layer()->bounds().size()));
 }

diff --git a/ash/wm/system_wallpaper_controller.h b/ash/wm/system_wallpaper_controller.h
@@ -35,7 +35,8 @@ class SystemWallpaperController : public aura::WindowObserver {
   // aura::WindowObserver overrides:
   void OnWindowBoundsChanged(aura::Window* root,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
  private:
   class HostContentLayerDelegate;

diff --git a/ash/wm/tablet_mode/tablet_mode_window_manager.cc b/ash/wm/tablet_mode/tablet_mode_window_manager.cc
@@ -159,7 +159,8 @@ void TabletModeWindowManager::OnWindowPropertyChanged(aura::Window* window,
 void TabletModeWindowManager::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   if (!IsContainerWindow(window))
     return;
   // Reposition all non maximizeable windows.

diff --git a/ash/wm/tablet_mode/tablet_mode_window_manager.h b/ash/wm/tablet_mode/tablet_mode_window_manager.h
@@ -70,7 +70,8 @@ class ASH_EXPORT TabletModeWindowManager
                                intptr_t old) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowVisibilityChanged(aura::Window* window, bool visible) override;
 
   // display::DisplayObserver:

diff --git a/ash/wm/window_dimmer.cc b/ash/wm/window_dimmer.cc
@@ -59,7 +59,8 @@ void WindowDimmer::SetDimOpacity(float target_opacity) {
 
 void WindowDimmer::OnWindowBoundsChanged(aura::Window* window,
                                          const gfx::Rect& old_bounds,
-                                         const gfx::Rect& new_bounds) {
+                                         const gfx::Rect& new_bounds,
+                                         ui::PropertyChangeReason reason) {
   if (window == parent_)
     window_->SetBounds(gfx::Rect(new_bounds.size()));
 }

diff --git a/ash/wm/window_dimmer.h b/ash/wm/window_dimmer.h
@@ -38,7 +38,8 @@ class ASH_EXPORT WindowDimmer : public aura::WindowObserver {
   // aura::WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowHierarchyChanging(const HierarchyChangeParams& params) override;
 

diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc
@@ -238,7 +238,8 @@ void WorkspaceLayoutManager::OnWindowDestroying(aura::Window* window) {
 void WorkspaceLayoutManager::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   if (root_window_ == window) {
     const wm::WMEvent wm_event(wm::WM_EVENT_DISPLAY_BOUNDS_CHANGED);
     AdjustAllWindowsBoundsForWorkAreaChange(&wm_event);

diff --git a/ash/wm/workspace/workspace_layout_manager.h b/ash/wm/workspace/workspace_layout_manager.h
@@ -72,7 +72,8 @@ class ASH_EXPORT WorkspaceLayoutManager
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // wm::ActivationChangeObserver overrides:
   void OnWindowActivating(ActivationReason reason,

diff --git a/chrome/browser/chromeos/lock_screen_apps/first_app_run_toast_manager.cc b/chrome/browser/chromeos/lock_screen_apps/first_app_run_toast_manager.cc
@@ -104,7 +104,8 @@ void FirstAppRunToastManager::OnAppWindowActivated(
 void FirstAppRunToastManager::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   if (toast_widget_ && window == app_window_->GetNativeWindow())
     AdjustToastWidgetBounds();
 }

diff --git a/chrome/browser/chromeos/lock_screen_apps/first_app_run_toast_manager.h b/chrome/browser/chromeos/lock_screen_apps/first_app_run_toast_manager.h
@@ -51,7 +51,8 @@ class FirstAppRunToastManager : public extensions::AppWindowRegistry::Observer,
   // aura::WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // extensions::AppWindowRegistry::Observer:
   void OnAppWindowActivated(extensions::AppWindow* app_window) override;

diff --git a/chrome/browser/ui/ash/chrome_keyboard_ui.cc b/chrome/browser/ui/ash/chrome_keyboard_ui.cc
@@ -77,7 +77,8 @@ class WindowBoundsChangeObserver : public aura::WindowObserver {
  private:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     ui_->UpdateInsetsForWindow(window);
   }
   void OnWindowDestroyed(aura::Window* window) override {
@@ -396,7 +397,8 @@ void ChromeKeyboardUI::ResetInsets() {
 
 void ChromeKeyboardUI::OnWindowBoundsChanged(aura::Window* window,
                                              const gfx::Rect& old_bounds,
-                                             const gfx::Rect& new_bounds) {
+                                             const gfx::Rect& new_bounds,
+                                             ui::PropertyChangeReason reason) {
   SetShadowAroundKeyboard();
 }
 

diff --git a/chrome/browser/ui/ash/chrome_keyboard_ui.h b/chrome/browser/ui/ash/chrome_keyboard_ui.h
@@ -79,7 +79,8 @@ class ChromeKeyboardUI : public keyboard::KeyboardUI,
   // aura::WindowObserver overrides:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowDestroyed(aura::Window* window) override;
   void OnWindowParentChanged(aura::Window* window,
                              aura::Window* parent) override;

diff --git a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
@@ -1279,7 +1279,8 @@ class TestWindowObserver : public aura::WindowObserver {
 
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     resize_calls_++;
   }
 

diff --git a/components/exo/shell_surface.cc b/components/exo/shell_surface.cc
@@ -1042,7 +1042,8 @@ void ShellSurface::OnPostWindowStateTypeChange(
 
 void ShellSurface::OnWindowBoundsChanged(aura::Window* window,
                                          const gfx::Rect& old_bounds,
-                                         const gfx::Rect& new_bounds) {
+                                         const gfx::Rect& new_bounds,
+                                         ui::PropertyChangeReason reason) {
   // TODO(domlaskowski): For BoundsMode::CLIENT, the configure callback does not
   // yet support resizing. See crbug.com/699746.
   if (bounds_mode_ == BoundsMode::CLIENT)

diff --git a/components/exo/shell_surface.h b/components/exo/shell_surface.h
@@ -273,7 +273,8 @@ class ShellSurface : public SurfaceTreeHost,
   // Overridden from aura::WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowDestroying(aura::Window* window) override;
 
   // Overridden from wm::ActivationChangeObserver:

diff --git a/components/ui_devtools/views/window_element.cc b/components/ui_devtools/views/window_element.cc
@@ -58,7 +58,8 @@ void WindowElement::OnWindowStackingChanged(aura::Window* window) {
 
 void WindowElement::OnWindowBoundsChanged(aura::Window* window,
                                           const gfx::Rect& old_bounds,
-                                          const gfx::Rect& new_bounds) {
+                                          const gfx::Rect& new_bounds,
+                                          ui::PropertyChangeReason reason) {
   DCHECK_EQ(window_, window);
   delegate()->OnUIElementBoundsChanged(this);
 }

diff --git a/components/ui_devtools/views/window_element.h b/components/ui_devtools/views/window_element.h
@@ -29,7 +29,8 @@ class WindowElement : public aura::WindowObserver, public UIElement {
   void OnWindowStackingChanged(aura::Window* window) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // UIElement:
   std::vector<std::pair<std::string, std::string>> GetCustomAttributes()

diff --git a/content/browser/media/capture/aura_window_capture_machine.cc b/content/browser/media/capture/aura_window_capture_machine.cc
@@ -407,7 +407,8 @@ void AuraWindowCaptureMachine::CopyOutputFinishedForVideo(
 void AuraWindowCaptureMachine::OnWindowBoundsChanged(
     aura::Window* window,
     const gfx::Rect& old_bounds,
-    const gfx::Rect& new_bounds) {
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(desktop_window_ && window == desktop_window_);
 

diff --git a/content/browser/media/capture/aura_window_capture_machine.h b/content/browser/media/capture/aura_window_capture_machine.h
@@ -45,7 +45,8 @@ class AuraWindowCaptureMachine : public media::VideoCaptureMachine,
   // Implements aura::WindowObserver.
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowAddedToRootWindow(aura::Window* window) override;
   void OnWindowRemovingFromRootWindow(aura::Window* window,

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -362,7 +362,8 @@ class RenderWidgetHostViewAura::WindowAncestorObserver
 
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     DCHECK(ancestors_.find(window) != ancestors_.end());
     if (new_bounds.origin() != old_bounds.origin())
       view_->HandleParentBoundsChanged();

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
@@ -449,7 +449,8 @@ class WebContentsViewAura::WindowObserver
 
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     if (window == host_window_ || window == view_->window_.get()) {
       SendScreenRects();
       if (old_bounds.origin() != new_bounds.origin()) {

diff --git a/mash/simple_wm/move_loop.cc b/mash/simple_wm/move_loop.cc
@@ -223,7 +223,8 @@ void MoveLoop::OnWindowHierarchyChanged(const HierarchyChangeParams& params) {
 
 void MoveLoop::OnWindowBoundsChanged(aura::Window* window,
                                      const gfx::Rect& old_bounds,
-                                     const gfx::Rect& new_bounds) {
+                                     const gfx::Rect& new_bounds,
+                                     ui::PropertyChangeReason reason) {
   DCHECK_EQ(window, target_);
   if (!changing_bounds_)
     Cancel();

diff --git a/mash/simple_wm/move_loop.h b/mash/simple_wm/move_loop.h
@@ -90,7 +90,8 @@ class MoveLoop : public aura::WindowObserver {
   void OnWindowHierarchyChanged(const HierarchyChangeParams& params) override;
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
   void OnWindowVisibilityChanged(aura::Window* window, bool visible) override;
 
   // The window this MoveLoop is acting on. |target_| is set to null if the

diff --git a/services/ui/ws/window_manager_client_unittest.cc b/services/ui/ws/window_manager_client_unittest.cc
@@ -111,7 +111,8 @@ class BoundsChangeObserver : public aura::WindowObserver {
   // Overridden from WindowObserver:
   void OnWindowBoundsChanged(aura::Window* window,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override {
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override {
     DCHECK_EQ(window, window_);
     EXPECT_TRUE(WindowServerTestBase::QuitRunLoop());
   }

diff --git a/ui/app_list/presenter/app_list_presenter_impl.cc b/ui/app_list/presenter/app_list_presenter_impl.cc
@@ -277,9 +277,11 @@ void AppListPresenterImpl::OnWindowFocused(aura::Window* gained_focus,
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListPresenterImpl,  aura::WindowObserver implementation:
-void AppListPresenterImpl::OnWindowBoundsChanged(aura::Window* root,
-                                                 const gfx::Rect& old_bounds,
-                                                 const gfx::Rect& new_bounds) {
+void AppListPresenterImpl::OnWindowBoundsChanged(
+    aura::Window* root,
+    const gfx::Rect& old_bounds,
+    const gfx::Rect& new_bounds,
+    ui::PropertyChangeReason reason) {
   if (presenter_delegate_)
     presenter_delegate_->UpdateBounds();
 }

diff --git a/ui/app_list/presenter/app_list_presenter_impl.h b/ui/app_list/presenter/app_list_presenter_impl.h
@@ -109,7 +109,8 @@ class APP_LIST_PRESENTER_EXPORT AppListPresenterImpl
   // aura::WindowObserver overrides:
   void OnWindowBoundsChanged(aura::Window* root,
                              const gfx::Rect& old_bounds,
-                             const gfx::Rect& new_bounds) override;
+                             const gfx::Rect& new_bounds,
+                             ui::PropertyChangeReason reason) override;
 
   // ui::ImplicitAnimationObserver overrides:
   void OnImplicitAnimationsCompleted() override;