Coverity PASS_BY_VALUE fixes

CID=2660,2611,2584,2582 BUG=none TEST=none Review URL: http://codereview.chromium.org/6736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79330 0039d316-1c4b-4281-b951-d872f2087c98
cbchan · Mar 24, 2011 · f25b54a · f25b54a
1 parent 1d56a9a
commit f25b54a
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/chrome/browser/autocomplete/autocomplete.h b/chrome/browser/autocomplete/autocomplete.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -701,7 +701,7 @@ class AutocompleteController : public ACProviderListener {
 // The data to log (via the metrics service) when the user selects an item
 // from the omnibox popup.
 struct AutocompleteLog {
-  AutocompleteLog(string16 text,
+  AutocompleteLog(const string16& text,
                   AutocompleteInput::Type input_type,
                   size_t selected_index,
                   size_t inline_autocompleted_length,

diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc
@@ -130,7 +130,7 @@ void ExtensionBookmarkEventRouter::Observe(BookmarkModel* model) {
 
 void ExtensionBookmarkEventRouter::DispatchEvent(Profile *profile,
                                                  const char* event_name,
-                                                 const std::string json_args) {
+                                                 const std::string& json_args) {
   if (profile->GetExtensionEventRouter()) {
     profile->GetExtensionEventRouter()->DispatchEventToRenderers(
         event_name, json_args, NULL, GURL());

diff --git a/chrome/browser/extensions/extension_bookmarks_module.h b/chrome/browser/extensions/extension_bookmarks_module.h
@@ -63,7 +63,7 @@ class ExtensionBookmarkEventRouter : public BookmarkModelObserver {
   // Helper to actually dispatch an event to extension listeners.
   void DispatchEvent(Profile* profile,
                      const char* event_name,
-                     const std::string json_args);
+                     const std::string& json_args);
 
   // These are stored so that Observe can be called multiple times safely.
   // This way the caller doesn't have to know whether it's already observing

diff --git a/chrome/browser/importer/mork_reader.h b/chrome/browser/importer/mork_reader.h
@@ -77,7 +77,7 @@ class MorkReader {
 
   // A MorkColumn describes a column of the table.
   struct MorkColumn {
-    MorkColumn(IDString i, const std::string& n) : id(i), name(n) { }
+    MorkColumn(const IDString& i, const std::string& n) : id(i), name(n) { }
 
     IDString id;
     std::string name;

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
@@ -1515,7 +1515,7 @@ void MetricsService::GetSettingsFromUploadNode(xmlNodePtr upload_node) {
 void MetricsService::GetSettingsFromUploadNodeRecursive(
     xmlNodePtr node,
     InheritedProperties props,
-    std::string path_prefix,
+    const std::string& path_prefix,
     bool uploadOn) {
   props.OverwriteWhereNeeded(node);
 

diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
@@ -305,7 +305,7 @@ class MetricsService : public NotificationObserver,
   void GetSettingsFromUploadNode(xmlNodePtr upload_node);
   void GetSettingsFromUploadNodeRecursive(xmlNodePtr node,
       InheritedProperties props,
-      std::string path_prefix,
+      const std::string& path_prefix,
       bool uploadOn);
 
   // NodeProbabilityTest gets called at every node in the tree traversal