Cleanup: IWYU for base/time.h. Also fix misc lint errors.

TBR=ben,brettw,oshima,rdsmith Review URL: https://chromiumcodereview.appspot.com/11087021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
cbchan · Oct 10, 2012 · efbee20 · efbee20
1 parent 7e30f64
commit efbee20
Show file tree

Hide file tree

Showing 45 changed files with 15 additions and 52 deletions.
diff --git a/ash/wm/session_state_animator.h b/ash/wm/session_state_animator.h
@@ -8,7 +8,6 @@
 #include "ash/ash_export.h"
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "base/timer.h"
 #include "ui/aura/root_window_observer.h"
 #include "ui/aura/window.h"
@@ -110,7 +109,7 @@ class ASH_EXPORT SessionStateAnimator : public aura::RootWindowObserver {
   // Drops back layer after |UNDO_SLOW_CLOSE| animation delay.
   void ScheduleDropBlackLayer();
 
-   // Apply animation |type| to all containers included in |container_mask|.
+  // Apply animation |type| to all containers included in |container_mask|.
   void StartAnimation(int container_mask,
                       AnimationType type);
 

diff --git a/base/message_pump_android.cc b/base/message_pump_android.cc
@@ -11,6 +11,7 @@
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/run_loop.h"
+#include "base/time.h"
 #include "jni/SystemMessageHandler_jni.h"
 
 using base::android::ScopedJavaLocalRef;

diff --git a/base/message_pump_android.h b/base/message_pump_android.h
@@ -9,10 +9,11 @@
 
 #include "base/compiler_specific.h"
 #include "base/message_pump.h"
-#include "base/time.h"
 
 namespace base {
+
 class RunLoop;
+class TimeTicks;
 
 // This class implements a MessagePump needed for TYPE_UI MessageLoops on
 // OS_ANDROID platform.

diff --git a/base/process_info.h b/base/process_info.h
@@ -7,10 +7,11 @@
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
-#include "base/time.h"
 
 namespace base {
 
+class Time;
+
 // Vends information about the current process.
 class BASE_EXPORT CurrentProcessInfo {
  public:

diff --git a/base/sys_info.h b/base/sys_info.h
@@ -10,7 +10,6 @@
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
-#include "base/time.h"
 #include "build/build_config.h"
 
 namespace base {

diff --git a/base/threading/worker_pool_posix.h b/base/threading/worker_pool_posix.h
@@ -30,7 +30,6 @@
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/location.h"
-#include "base/time.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/pending_task.h"

diff --git a/base/tracked_objects.h b/base/tracked_objects.h
@@ -18,7 +18,6 @@
 #include "base/location.h"
 #include "base/profiler/alternate_timer.h"
 #include "base/profiler/tracked_time.h"
-#include "base/time.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_local_storage.h"
 #include "base/tracking_info.h"

diff --git a/chrome/browser/automation/automation_tab_tracker.h b/chrome/browser/automation/automation_tab_tracker.h
@@ -7,7 +7,6 @@
 
 #include <map>
 
-#include "base/time.h"
 #include "chrome/browser/automation/automation_resource_tracker.h"
 
 namespace content {

diff --git a/chrome/browser/browsing_data/browsing_data_file_system_helper.h b/chrome/browser/browsing_data/browsing_data_file_system_helper.h
@@ -13,7 +13,6 @@
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/synchronization/lock.h"
-#include "base/time.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/fileapi/file_system_types.h"

diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper.h b/chrome/browser/browsing_data/browsing_data_quota_helper.h
@@ -12,7 +12,6 @@
 #include "base/memory/ref_counted.h"
 #include "base/message_loop_proxy.h"
 #include "base/sequenced_task_runner_helpers.h"
-#include "base/time.h"
 #include "content/public/browser/browser_thread.h"
 #include "webkit/quota/quota_types.h"
 

diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.h b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.h
@@ -13,7 +13,6 @@
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
-#include "base/time.h"
 #include "chrome/browser/browsing_data/browsing_data_quota_helper.h"
 #include "content/public/browser/browser_thread.h"
 #include "webkit/quota/quota_types.h"

diff --git a/chrome/browser/chromeos/login/user_manager.h b/chrome/browser/chromeos/login/user_manager.h
@@ -9,7 +9,6 @@
 
 #include "ash/desktop_background/desktop_background_resources.h"
 #include "base/memory/singleton.h"
-#include "base/time.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/ui/webui/options/chromeos/set_wallpaper_options_handler.h"
 

diff --git a/chrome/browser/extensions/extension_pref_store.h b/chrome/browser/extensions/extension_pref_store.h
@@ -7,7 +7,6 @@
 
 #include <string>
 
-#include "base/time.h"
 #include "chrome/browser/extensions/extension_pref_value_map.h"
 #include "chrome/browser/prefs/value_map_pref_store.h"
 

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
@@ -18,7 +18,6 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
-#include "base/time.h"
 #include "base/tuple.h"
 #include "chrome/browser/api/prefs/pref_change_registrar.h"
 #include "chrome/browser/extensions/app_shortcut_manager.h"

diff --git a/chrome/browser/net/chrome_net_log.h b/chrome/browser/net/chrome_net_log.h
@@ -9,7 +9,6 @@
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "base/synchronization/lock.h"
-#include "base/time.h"
 #include "net/base/net_log.h"
 
 class LoadTimingObserver;

diff --git a/chrome/browser/net/crl_set_fetcher.h b/chrome/browser/net/crl_set_fetcher.h
@@ -9,7 +9,6 @@
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
-#include "base/time.h"
 #include "chrome/browser/component_updater/component_updater_service.h"
 
 class FilePath;

diff --git a/chrome/browser/password_manager/password_store_mac_internal.h b/chrome/browser/password_manager/password_store_mac_internal.h
@@ -10,7 +10,6 @@
 #include <string>
 #include <vector>
 
-#include "base/time.h"
 #include "crypto/apple_keychain.h"
 
 using crypto::AppleKeychain;
@@ -170,6 +169,6 @@ std::vector<content::PasswordForm*> GetPasswordsForForms(
     const AppleKeychain& keychain,
     std::vector<content::PasswordForm*>* database_forms);
 
-}  // internal_keychain_helpers
+}  // namespace internal_keychain_helpers
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_MAC_INTERNAL_H_
diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h
@@ -9,7 +9,6 @@
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
-#include "base/time.h"
 #include "google_apis/gaia/gaia_auth_consumer.h"
 #include "google_apis/gaia/gaia_auth_fetcher.h"
 #include "google_apis/gaia/google_service_auth_error.h"

diff --git a/chrome/browser/sync/glue/typed_url_change_processor.h b/chrome/browser/sync/glue/typed_url_change_processor.h
@@ -10,7 +10,6 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "chrome/browser/sync/glue/data_type_error_handler.h"
 #include "chrome/browser/sync/glue/sync_backend_host.h"
 #include "chrome/browser/sync/glue/typed_url_model_associator.h"

diff --git a/chrome/browser/sync/test/integration/passwords_helper.h b/chrome/browser/sync/test/integration/passwords_helper.h
@@ -7,7 +7,6 @@
 
 #include <vector>
 
-#include "base/time.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"

diff --git a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h
@@ -13,7 +13,6 @@
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #import "chrome/browser/ui/cocoa/chrome_browser_window.h"
 #import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"

diff --git a/chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h b/chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui_handler.h
@@ -6,7 +6,6 @@
 #define CHROME_BROWSER_UI_WEBUI_SUGGESTIONS_INTERNALS_SUGGESTIONS_INTERNALS_UI_HANDLER_H_
 
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "chrome/browser/ui/webui/ntp/suggestions_combiner.h"
 #include "content/public/browser/web_ui_message_handler.h"
 

diff --git a/chrome/renderer/spellchecker/spellcheck.h b/chrome/renderer/spellchecker/spellcheck.h
@@ -15,7 +15,6 @@
 #include "base/memory/weak_ptr.h"
 #include "base/platform_file.h"
 #include "base/string16.h"
-#include "base/time.h"
 #include "chrome/renderer/spellchecker/spellcheck_worditerator.h"
 #include "content/public/renderer/render_process_observer.h"
 #include "ipc/ipc_platform_file.h"

diff --git a/chromeos/disks/mock_disk_mount_manager.h b/chromeos/disks/mock_disk_mount_manager.h
@@ -8,7 +8,6 @@
 #include <string>
 
 #include "base/observer_list.h"
-#include "base/time.h"
 #include "chromeos/disks/disk_mount_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"

diff --git a/content/browser/device_orientation/provider_impl.h b/content/browser/device_orientation/provider_impl.h
@@ -11,7 +11,6 @@
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
-#include "base/time.h"
 #include "content/browser/device_orientation/data_fetcher.h"
 #include "content/browser/device_orientation/device_data.h"
 #include "content/browser/device_orientation/provider.h"

diff --git a/content/browser/geolocation/win7_location_api_win.h b/content/browser/geolocation/win7_location_api_win.h
@@ -11,7 +11,6 @@
 #include <locationapi.h>
 #include <sensors.h>
 
-#include "base/time.h"
 #include "base/win/scoped_com_initializer.h"
 #include "content/common/content_export.h"
 

diff --git a/content/browser/renderer_host/gesture_event_filter.h b/content/browser/renderer_host/gesture_event_filter.h
@@ -9,7 +9,6 @@
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "base/timer.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 
@@ -130,6 +129,6 @@ class GestureEventFilter {
   DISALLOW_COPY_AND_ASSIGN(GestureEventFilter);
 };
 
-} // namespace content
+}  // namespace content
 
-#endif // CONTENT_BROWSER_RENDERER_HOST_GESTURE_EVENT_FILTER_H_
+#endif  // CONTENT_BROWSER_RENDERER_HOST_GESTURE_EVENT_FILTER_H_
diff --git a/content/browser/renderer_host/resource_request_info_impl.h b/content/browser/renderer_host/resource_request_info_impl.h
@@ -11,7 +11,6 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/supports_user_data.h"
-#include "base/time.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/process_type.h"

diff --git a/content/common/file_utilities_messages.h b/content/common/file_utilities_messages.h
@@ -4,7 +4,6 @@
 
 // Multiply-included message file, so no include guard.
 
-#include "base/time.h"
 #include "content/public/common/common_param_traits.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_param_traits.h"

diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h
@@ -10,7 +10,6 @@
 #include <vector>
 
 #include "base/observer_list.h"
-#include "base/time.h"
 #include "base/timer.h"
 #include "build/build_config.h"
 #include "content/common/child_process.h"

diff --git a/media/audio/audio_output_controller.h b/media/audio/audio_output_controller.h
@@ -9,7 +9,6 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/synchronization/lock.h"
-#include "base/time.h"
 #include "media/audio/audio_buffers_state.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_manager.h"

diff --git a/media/audio/linux/cras_input.h b/media/audio/linux/cras_input.h
@@ -12,7 +12,6 @@
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
-#include "base/time.h"
 #include "media/audio/audio_input_stream_impl.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_parameters.h"

diff --git a/media/audio/mac/audio_low_latency_input_mac.h b/media/audio/mac/audio_low_latency_input_mac.h
@@ -42,7 +42,6 @@
 #include "base/atomicops.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/synchronization/lock.h"
-#include "base/time.h"
 #include "media/audio/audio_io.h"
 #include "media/audio/audio_input_stream_impl.h"
 #include "media/audio/audio_parameters.h"

diff --git a/media/webm/webm_tracks_parser.h b/media/webm/webm_tracks_parser.h
@@ -9,7 +9,6 @@
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "media/webm/webm_content_encodings_client.h"
 #include "media/webm/webm_parser.h"
 

diff --git a/net/base/crl_set.cc b/net/base/crl_set.cc
@@ -9,6 +9,7 @@
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/time.h"
 #include "base/values.h"
 #include "crypto/sha2.h"
 #include "net/base/crl_set.h"
@@ -71,8 +72,8 @@ CRLSet::~CRLSet() {
 // header_bytes consists of a JSON dictionary with the following keys:
 //   Version (int): currently 0
 //   ContentType (string): "CRLSet" or "CRLSetDelta" (magic value)
-//   DeltaFrom (int32): if this is a delta update (see below), then this contains
-//       the sequence number of the base CRLSet.
+//   DeltaFrom (int32): if this is a delta update (see below), then this
+//       contains the sequence number of the base CRLSet.
 //   Sequence (int32): the monotonic sequence number of this CRL set.
 //
 // A delta CRLSet is similar to a CRLSet:
@@ -441,7 +442,7 @@ bool CRLSet::ApplyDelta(const base::StringPiece& in_data,
 
 // static
 bool CRLSet::GetIsDeltaUpdate(const base::StringPiece& in_data,
-                              bool *is_delta) {
+                              bool* is_delta) {
   base::StringPiece data(in_data);
   scoped_ptr<base::DictionaryValue> header_dict(ReadHeader(&data));
   if (!header_dict.get())

diff --git a/net/base/crl_set.h b/net/base/crl_set.h
@@ -12,7 +12,6 @@
 
 #include "base/memory/ref_counted.h"
 #include "base/string_piece.h"
-#include "base/time.h"
 #include "net/base/net_export.h"
 
 namespace base {

diff --git a/remoting/base/running_average.h b/remoting/base/running_average.h
@@ -17,15 +17,14 @@
 
 #include "base/basictypes.h"
 #include "base/synchronization/lock.h"
-#include "base/time.h"
 
 namespace remoting {
 
 class RunningAverage {
  public:
   // Construct a running average counter for a specific window size. The
   // |windows_size| most recent values are kept and the average is reported.
-  RunningAverage(int window_size);
+  explicit RunningAverage(int window_size);
 
   virtual ~RunningAverage();
 

diff --git a/remoting/client/chromoting_client.h b/remoting/client/chromoting_client.h
@@ -12,7 +12,6 @@
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
-#include "base/time.h"
 #include "remoting/client/client_config.h"
 #include "remoting/client/chromoting_stats.h"
 #include "remoting/protocol/client_stub.h"

diff --git a/remoting/host/audio_scheduler.h b/remoting/host/audio_scheduler.h
@@ -8,7 +8,6 @@
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 
 namespace base {
 class SingleThreadTaskRunner;

diff --git a/ui/base/gestures/gesture_types.h b/ui/base/gestures/gesture_types.h
@@ -6,7 +6,6 @@
 #define UI_BASE_GESTURES_GESTURE_TYPES_H_
 
 #include "base/logging.h"
-#include "base/time.h"
 #include "ui/base/events/event_constants.h"
 #include "ui/gfx/rect.h"
 

diff --git a/webkit/appcache/appcache_service.h b/webkit/appcache/appcache_service.h
@@ -11,7 +11,6 @@
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/time.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_errors.h"
 #include "webkit/appcache/appcache_export.h"