Skip to content

Commit

Permalink
Revert 119540 - Add StringToSizeT to base/string_number_conversions.
Browse files Browse the repository at this point in the history
Compile error in webrequest_api.cc.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9296002

TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9296027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119549 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
yoz@chromium.org committed Jan 28, 2012
1 parent 925f94e commit d1bafad
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
12 changes: 10 additions & 2 deletions base/string_number_conversions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,14 @@ bool StringToInt(const StringPiece16& input, int* output) {
return String16ToIntImpl(input, output);
}

bool StringToUint(const StringPiece& input, unsigned* output) {
return StringToIntImpl(input, output);
}

bool StringToUint(const StringPiece16& input, unsigned* output) {
return String16ToIntImpl(input, output);
}

bool StringToInt64(const StringPiece& input, int64* output) {
return StringToIntImpl(input, output);
}
Expand All @@ -410,11 +418,11 @@ bool StringToInt64(const StringPiece16& input, int64* output) {
return String16ToIntImpl(input, output);
}

bool StringToSizeT(const StringPiece& input, size_t* output) {
bool StringToUint64(const StringPiece& input, uint64* output) {
return StringToIntImpl(input, output);
}

bool StringToSizeT(const StringPiece16& input, size_t* output) {
bool StringToUint64(const StringPiece16& input, uint64* output) {
return String16ToIntImpl(input, output);
}

Expand Down
7 changes: 5 additions & 2 deletions base/string_number_conversions.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,14 @@ BASE_EXPORT std::string DoubleToString(double value);
BASE_EXPORT bool StringToInt(const StringPiece& input, int* output);
BASE_EXPORT bool StringToInt(const StringPiece16& input, int* output);

BASE_EXPORT bool StringToUint(const StringPiece& input, unsigned* output);
BASE_EXPORT bool StringToUint(const StringPiece16& input, unsigned* output);

BASE_EXPORT bool StringToInt64(const StringPiece& input, int64* output);
BASE_EXPORT bool StringToInt64(const StringPiece16& input, int64* output);

BASE_EXPORT bool StringToSizeT(const StringPiece& input, size_t* output);
BASE_EXPORT bool StringToSizeT(const StringPiece16& input, size_t* output);
BASE_EXPORT bool StringToUint64(const StringPiece& input, uint64* output);
BASE_EXPORT bool StringToUint64(const StringPiece16& input, uint64* output);

// For floating-point conversions, only conversions of input strings in decimal
// form are defined to work. Behavior with strings representing floating-point
Expand Down

0 comments on commit d1bafad

Please sign in to comment.