Skip to content

Commit

Permalink
build: make about:credits have proper inputs.
Browse files Browse the repository at this point in the history
R=thestig@chromium.org
BUG=none
TEST=touch about_credits.tmpl && rebuild  # actually works

Review URL: https://codereview.chromium.org/807713003

Cr-Commit-Position: refs/heads/master@{#308730}
  • Loading branch information
danbeam authored and Commit bot committed Dec 17, 2014
1 parent ef94d36 commit c7776c7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
13 changes: 9 additions & 4 deletions chrome/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -789,10 +789,15 @@ grit("resources") {
action("about_credits") {
script = "//tools/licenses.py"

# TODO(phajdan.jr): input dependencies so this can be regenerated
# automatically when one of the credits changes. The way this should work is
# that licenses.py should write a .d file listing the input dependencies (see
# "depfile" in GN).
inputs = [
# This is not a complete list. TODO(phajdan.jr, dbeam): licenses.py needs to
# generate a .d file with all the licenses/credits that about:credits uses.
# Then about:credits will automatically rebuild when one of them changes.
# See: depfile in gn's documentation (gn help depfile).
"resources/about_credits.tmpl",
"resources/about_credits_entry.tmpl",
]

outputs = [
about_credits_file,
]
Expand Down
5 changes: 4 additions & 1 deletion chrome/chrome_resources.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,11 @@
},
'action_name': 'generate_about_credits',
'inputs': [
# TODO(phajdan.jr): make licenses.py print inputs too.
# TODO(phajdan.jr): make licenses.py print license input files so
# about:credits gets rebuilt when one changes.
'<(generator_path)',
'browser/resources/about_credits.tmpl',
'browser/resources/about_credits_entry.tmpl',
],
'outputs': [
'<(about_credits_file)',
Expand Down

0 comments on commit c7776c7

Please sign in to comment.