Skip to content

Commit

Permalink
base: Add/Fix namespace closing comments.
Browse files Browse the repository at this point in the history
A namespace foo should end with a comment "// namespace foo", this
corrects errors in base/.

BUG=464816

Review URL: https://codereview.chromium.org/981803003

Cr-Commit-Position: refs/heads/master@{#319543}
  • Loading branch information
danakj authored and Commit bot committed Mar 7, 2015
1 parent c7f5ee5 commit c3762b9
Show file tree
Hide file tree
Showing 31 changed files with 37 additions and 36 deletions.
2 changes: 1 addition & 1 deletion base/android/jni_string.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jstring ConvertUTF16ToJavaStringImpl(JNIEnv* env,
return result;
}

}
} // namespace

namespace base {
namespace android {
Expand Down
2 changes: 1 addition & 1 deletion base/atomicops_internals_arm64_gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ inline Atomic64 Release_Load(volatile const Atomic64* ptr) {
return *ptr;
}

} // namespace base::subtle
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_ARM64_GCC_H_
2 changes: 1 addition & 1 deletion base/atomicops_internals_arm_gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ inline Atomic32 Release_Load(volatile const Atomic32* ptr) {
return *ptr;
}

} // namespace base::subtle
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_ARM_GCC_H_
4 changes: 2 additions & 2 deletions base/atomicops_internals_atomicword_compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ inline AtomicWord Release_Load(volatile const AtomicWord* ptr) {
reinterpret_cast<volatile const Atomic32*>(ptr));
}

} // namespace base::subtle
} // namespace base
} // namespace subtle
} // namespace base

#endif // !defined(ARCH_CPU_64_BITS)

Expand Down
2 changes: 1 addition & 1 deletion base/atomicops_internals_gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ inline Atomic32 Release_Load(volatile const Atomic32* ptr) {
return *ptr;
}

} // namespace base::subtle
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_GCC_H_
Expand Down
4 changes: 2 additions & 2 deletions base/atomicops_internals_mac.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ inline Atomic64 Release_Load(volatile const Atomic64* ptr) {

#endif // defined(__LP64__)

} // namespace base::subtle
} // namespace base
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_MAC_H_
4 changes: 2 additions & 2 deletions base/atomicops_internals_mips_gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ inline Atomic64 Release_Load(volatile const Atomic64* ptr) {
}
#endif

} // namespace base::subtle
} // namespace base
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_MIPS_GCC_H_
4 changes: 2 additions & 2 deletions base/atomicops_internals_portable.h
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ inline Atomic64 Release_Load(volatile const Atomic64* ptr) {
}

#endif // defined(ARCH_CPU_64_BITS)
}
} // namespace base::subtle
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_PORTABLE_H_
4 changes: 2 additions & 2 deletions base/atomicops_internals_x86_gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ inline Atomic64 Release_CompareAndSwap(volatile Atomic64* ptr,

#endif // defined(__x86_64__)

} // namespace base::subtle
} // namespace base
} // namespace subtle
} // namespace base

#undef ATOMICOPS_COMPILER_BARRIER

Expand Down
2 changes: 1 addition & 1 deletion base/atomicops_internals_x86_msvc.h
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ inline Atomic64 Release_CompareAndSwap(volatile Atomic64* ptr,

#endif // defined(_WIN64)

} // namespace base::subtle
} // namespace subtle
} // namespace base

#endif // BASE_ATOMICOPS_INTERNALS_X86_MSVC_H_
2 changes: 1 addition & 1 deletion base/auto_reset.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ class AutoReset {
DISALLOW_COPY_AND_ASSIGN(AutoReset);
};

}
} // namespace base

#endif // BASE_AUTO_RESET_H_
2 changes: 1 addition & 1 deletion base/containers/hash_tables.h
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ struct hash<std::pair<Type1, Type2> > {
}
};

}
} // namespace BASE_HASH_NAMESPACE

#undef DEFINE_PAIR_HASH_FUNCTION_START
#undef DEFINE_PAIR_HASH_FUNCTION_END
Expand Down
2 changes: 1 addition & 1 deletion base/guid_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ std::string RandomDataToGUIDString(const uint64 bytes[2]) {
bytes[1] & 0x0000ffffffffffffULL);
}

} // namespace guid
} // namespace base
2 changes: 1 addition & 1 deletion base/guid_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ std::string GenerateGUID() {
return WideToUTF8(guid_string.substr(1, guid_string.length() - 2));
}

} // namespace guid
} // namespace base
2 changes: 1 addition & 1 deletion base/path_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace base {
// Mac and Android.
bool PathProviderPosix(int key, FilePath* result);
#endif
}
} // namespace base

namespace {

Expand Down
2 changes: 1 addition & 1 deletion base/path_service.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
namespace base {
class FilePath;
class ScopedPathOverride;
} // namespace
} // namespace base

// The path service is a global table mapping keys to file system paths. It is
// OK to use this service from multiple threads.
Expand Down
2 changes: 1 addition & 1 deletion base/process/memory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ bool UncheckedCalloc(size_t num_items, size_t size, void** result) {

#endif

}
} // namespace base
2 changes: 1 addition & 1 deletion base/process/process_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -324,4 +324,4 @@ int Process::GetPriority() const {
return getpriority(PRIO_PROCESS, process_);
}

} // namspace base
} // namespace base
2 changes: 1 addition & 1 deletion base/stl_util_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ComparableValue {
int value_;
};

}
} // namespace

namespace base {
namespace {
Expand Down
2 changes: 1 addition & 1 deletion base/strings/nullable_string16.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ inline bool operator!=(const NullableString16& a, const NullableString16& b) {
BASE_EXPORT std::ostream& operator<<(std::ostream& out,
const NullableString16& value);

} // namespace
} // namespace base

#endif // BASE_STRINGS_NULLABLE_STRING16_H_
2 changes: 1 addition & 1 deletion base/strings/utf_offset_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -293,4 +293,4 @@ TEST(UTFOffsetStringConversionsTest, MergeSequentialAdjustments) {
EXPECT_EQ(2u, adjustments_on_adjusted_string[5].output_length);
}

} // namaspace base
} // namespace base
2 changes: 1 addition & 1 deletion base/strings/utf_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,4 @@ TEST(UTFStringConversionsTest, ConvertMultiString) {
EXPECT_EQ(expected, converted);
}

} // base
} // namespace base
2 changes: 1 addition & 1 deletion base/test/null_task_runner.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ bool NullTaskRunner::RunsTasksOnCurrentThread() const {
return true;
}

} // namespace
} // namespace base
2 changes: 1 addition & 1 deletion base/test/null_task_runner.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ class NullTaskRunner : public base::SingleThreadTaskRunner {
DISALLOW_COPY_AND_ASSIGN(NullTaskRunner);
};

} // namespace
} // namespace base
2 changes: 1 addition & 1 deletion base/threading/thread_restrictions.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class NestedMessagePumpAndroid;
class RenderWidgetResizeHelper;
class ScopedAllowWaitForAndroidLayoutTests;
class TextInputClientMac;
}
} // namespace content
namespace dbus {
class Bus;
}
Expand Down
3 changes: 2 additions & 1 deletion base/trace_event/memory_dump_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ const char* DumpPointTypeToString(const DumpPointType& dump_point_type) {
NOTREACHED();
return "UNKNOWN";
}
}

} // namespace

// TODO(primiano): this should be smarter and should do something similar to
// trace event synthetic delays.
Expand Down
2 changes: 1 addition & 1 deletion base/trace_event/memory_dump_manager_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,5 @@ TEST_F(MemoryDumpManagerTest, DisableFailingDumpers) {
DisableTracing();
}

} // namespace trace_Event
} // namespace trace_event
} // namespace base
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ TEST(ProcessMemoryTotalsDumpProviderTest, DumpRSS) {
EXPECT_EQ(rss_after - rss_before, kAllocSize);
}

} // namespace trace_Event
} // namespace trace_event
} // namespace base
2 changes: 1 addition & 1 deletion base/value_conversions.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ BASE_EXPORT bool GetValueAsFilePath(const Value& value, FilePath* file_path);
BASE_EXPORT StringValue* CreateTimeDeltaValue(const TimeDelta& time);
BASE_EXPORT bool GetValueAsTimeDelta(const Value& value, TimeDelta* time);

} // namespace
} // namespace base

#endif // BASE_VALUE_CONVERSIONS_H_
2 changes: 1 addition & 1 deletion base/vlog.cc
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,4 @@ bool MatchVlogPattern(const base::StringPiece& string,
return false;
}

} // namespace
} // namespace logging
2 changes: 1 addition & 1 deletion base/win/scoped_variant.h
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,6 @@ class BASE_EXPORT ScopedVariant {
};

} // namespace win
} // namesoace base
} // namespace base

#endif // BASE_WIN_SCOPED_VARIANT_H_

0 comments on commit c3762b9

Please sign in to comment.