Localize service names.

There are a couple of services that have hard coded names in English. Localize them. Change-Id: Ice25e5d5a70304e0954757c619738dbd9264d1eb Reviewed-on: https://chromium-review.googlesource.com/1054991 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#558593}
cbchan · May 15, 2018 · a7f5d9d · a7f5d9d
1 parent fcf7b16
commit a7f5d9d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
@@ -3272,6 +3272,11 @@ are declared in build/common.gypi.
           Media File Checker
         </message>
       </if>
+      <if expr="enable_printing">
+        <message name="IDS_UTILITY_PROCESS_PDF_COMPOSITOR_SERVICE_NAME" desc="The name of the utility process used for PDF compositing.">
+          PDF Compositor Service
+        </message>
+      </if>
       <if expr="enable_print_preview or (enable_printing and is_win)">
         <message name="IDS_UTILITY_PROCESS_PRINTING_SERVICE_NAME" desc="The name of the utility process used for printing conversions.">
           Printing Service
@@ -3280,6 +3285,9 @@ are declared in build/common.gypi.
       <message name="IDS_UTILITY_PROCESS_PATCH_NAME" desc="The name of the utility process used for patching file operations.">
         Patch Service
       </message>
+      <message name="IDS_UTILITY_PROCESS_PROFILING_SERVICE_NAME" desc="The name of the utility process used for heap profiling.">
+        Profiling Service
+      </message>
       <message name="IDS_UTILITY_PROCESS_UNZIP_NAME" desc="The name of the utility process used for unzipping files.">
         Unzip Service
       </message>

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
@@ -3399,8 +3399,8 @@ void ChromeContentBrowserClient::RegisterInProcessServices(
 void ChromeContentBrowserClient::RegisterOutOfProcessServices(
     OutOfProcessServiceMap* services) {
 #if BUILDFLAG(ENABLE_PRINTING)
-  (*services)[printing::mojom::kServiceName] =
-      base::ASCIIToUTF16("PDF Compositor Service");
+  (*services)[printing::mojom::kServiceName] = l10n_util::GetStringUTF16(
+      IDS_UTILITY_PROCESS_PDF_COMPOSITOR_SERVICE_NAME);
 #endif
 
 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) || \
@@ -3410,7 +3410,7 @@ void ChromeContentBrowserClient::RegisterOutOfProcessServices(
 #endif
 
   (*services)[heap_profiling::mojom::kServiceName] =
-      base::ASCIIToUTF16("Profiling Service");
+      l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_PROFILING_SERVICE_NAME);
 
 #if BUILDFLAG(ENABLE_EXTENSIONS) || defined(OS_ANDROID)
   (*services)[chrome::mojom::kMediaGalleryUtilServiceName] =