Skip to content

Commit

Permalink
Revert 243967 "Use a Finch Experiment to control the Browser Bla..."
Browse files Browse the repository at this point in the history
> Use a Finch Experiment to control the Browser Blacklist
> 
> Also increase the states stored in the register to prevent
> the setup code from running multiple times per version if
> it fails to start one time.
> 
> BUG=329023
> 
> Review URL: https://codereview.chromium.org/120963002

TBR=csharp@chromium.org

Review URL: https://codereview.chromium.org/132043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244026 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
noamsml@google.com committed Jan 10, 2014
1 parent 8261d96 commit 86ba1fe
Show file tree
Hide file tree
Showing 14 changed files with 44 additions and 382 deletions.
1 change: 0 additions & 1 deletion chrome/browser/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ include_rules = [
"+ash",
"+chrome/app",
"+chrome/installer",
"+chrome_elf/blacklist",
"+chromeos",
"+components/autofill/content/browser",
"+components/autofill/content/common",
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/chrome_browser_main_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "base/win/windows_version.h"
#include "base/win/wrapped_window_proc.h"
#include "chrome/browser/browser_util_win.h"
#include "chrome/browser/chrome_elf_init_win.h"
#include "chrome/browser/install_verification/win/install_verification.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_shortcut_manager.h"
Expand Down Expand Up @@ -253,8 +252,6 @@ void ChromeBrowserMainPartsWin::PostBrowserStart() {
FROM_HERE,
base::Bind(&VerifyInstallation),
base::TimeDelta::FromSeconds(45));

InitializeChromeElf();
}

// static
Expand Down
111 changes: 0 additions & 111 deletions chrome/browser/chrome_elf_init_unittest_win.cc

This file was deleted.

103 changes: 0 additions & 103 deletions chrome/browser/chrome_elf_init_win.cc

This file was deleted.

15 changes: 0 additions & 15 deletions chrome/browser/chrome_elf_init_win.h

This file was deleted.

3 changes: 0 additions & 3 deletions chrome/chrome_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@
'browser/chrome_browser_main_win.h',
'browser/chrome_content_browser_client.cc',
'browser/chrome_content_browser_client.h',
'browser/chrome_elf_init_win.cc',
'browser/chrome_elf_init_win.h',
'browser/chrome_notification_types.h',
'browser/chrome_page_zoom.cc',
'browser/chrome_page_zoom.h',
Expand Down Expand Up @@ -3317,7 +3315,6 @@
'dependencies': [
'chrome_process_finder',
'installer_util_strings',
'../chrome_elf/chrome_elf.gyp:blacklist',
'../google_update/google_update.gyp:google_update',
'../third_party/iaccessible2/iaccessible2.gyp:iaccessible2',
'../third_party/isimpledom/isimpledom.gyp:isimpledom',
Expand Down
1 change: 0 additions & 1 deletion chrome/chrome_tests_unit.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,6 @@
'browser/captive_portal/testing_utils.cc',
'browser/captive_portal/testing_utils.h',
'browser/chrome_browser_application_mac_unittest.mm',
'browser/chrome_elf_init_unittest_win.cc',
'browser/chrome_page_zoom_unittest.cc',
'browser/chrome_process_singleton_win_unittest.cc',
'browser/chromeos/accessibility/magnification_manager_unittest.cc',
Expand Down
6 changes: 1 addition & 5 deletions chrome_elf/blacklist.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
{
'target_name': 'blacklist',
'type': 'static_library',
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)',
],
'sources': [
'blacklist/blacklist.cc',
'blacklist/blacklist.h',
Expand All @@ -20,8 +17,7 @@
# as that would risk pulling in base's link-time dependencies which
# chrome_elf cannot do.
'../base/base.gyp:base_static',
'../chrome/chrome.gyp:chrome_version_header',
'../sandbox/sandbox.gyp:sandbox',
'../sandbox/sandbox.gyp:sandbox',
],
},
{
Expand Down
Loading

0 comments on commit 86ba1fe

Please sign in to comment.