Skip to content

Commit

Permalink
Do not use \u unicode characters directly in libaddressinput unit tests.
Browse files Browse the repository at this point in the history
VisualStudio does not understand it \u escape sequences like \u00E8 in
UTF8 strings. The fix is to use Wide strings and convert them into UTF8
using base::WideToUTF8() utility.

BUG=395401

Review URL: https://codereview.chromium.org/403233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284629 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
rouslan@chromium.org committed Jul 22, 2014
1 parent cb41ac8 commit 7f2dc09
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"
#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_problem.h"
Expand Down Expand Up @@ -247,7 +248,7 @@ TEST_F(AddressValidatorTest, BasicValidation) {
EXPECT_TRUE(problems.empty());

// Ignore diacriticals.
address.administrative_area = "T\u00E9xas";
address.administrative_area = base::WideToUTF8(L"T\u00E9xas");
problems.clear();
EXPECT_EQ(AddressValidator::SUCCESS,
validator_->ValidateAddress(address, NULL, &problems));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@

#include "third_party/libaddressinput/src/cpp/src/util/string_compare.h"

#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace {

TEST(ChromeStringCompareTest, IgnoreDiacritics) {
i18n::addressinput::StringCompare sc;
EXPECT_TRUE(sc.NaturalEquals("Texas", "T\u00E9xas"));
EXPECT_TRUE(sc.NaturalEquals("Texas", base::WideToUTF8(L"T\u00E9xas")));
}

TEST(ChromeStringCompareTest, IgnoreCapitalization) {
Expand Down

0 comments on commit 7f2dc09

Please sign in to comment.