Skip to content

Commit

Permalink
Blink/Layout Tests/Scripts - applied the additional driver flags to t…
Browse files Browse the repository at this point in the history
…he check-sys-deps run as well.

When you must disable the sandbox, you want to disable it for any
content_shell run, including check-sys-deps runs, instead of using
--nocheck-sys-deps.

Bug: None
Change-Id: I90be01ad4034e5c93335ca55430ba550c389380d
Reviewed-on: https://chromium-review.googlesource.com/964741
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543658}
  • Loading branch information
phistuck authored and Commit Bot committed Mar 16, 2018
1 parent 7aecde2 commit 77b2f6c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,7 @@ Philipp Hancke <fippo@andyet.net>
Philipp Hancke <philipp.hancke@googlemail.com>
Philippe Beauchamp <philippe.beauchamp@gmail.com>
Philippe Beaudoin <philippe.beaudoin@gmail.com>
PhistucK <phistuck@gmail.com>
Pierre Neter <pierreneter@gmail.com>
Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
Po-Chun Chang <pochang0403@gmail.com>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,10 @@ def check_sys_deps(self, needs_http):
"""
cmd = [self._path_to_driver(), '--check-layout-test-sys-deps']

additional_flags = self.get_option('additional_driver_flag', [])
if additional_flags:
cmd.append(additional_flags[0])

local_error = ScriptError()

def error_handler(script_error):
Expand Down

0 comments on commit 77b2f6c

Please sign in to comment.