Skip to content

Commit

Permalink
PPAPI: Make ASSERT macros print values of operands
Browse files Browse the repository at this point in the history
With this patch, if one of our ASSERT macros fails, the error
string will contain the expected and actual values.

I made a browser test for it. I would prefer a
unit test, but I didn't want to have to mix test_case.h with
our unit tests.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246129

Review URL: https://codereview.chromium.org/123463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246757 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
dmichael@chromium.org committed Jan 24, 2014
1 parent 71c10c5 commit 6d85286
Show file tree
Hide file tree
Showing 17 changed files with 794 additions and 134 deletions.
2 changes: 2 additions & 0 deletions chrome/test/ppapi/ppapi_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1692,6 +1692,8 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, FlashDRM) {
TEST_PPAPI_IN_PROCESS(TalkPrivate)
TEST_PPAPI_OUT_OF_PROCESS(TalkPrivate)

TEST_PPAPI_OUT_OF_PROCESS(TestInternals)

#if defined(OS_CHROMEOS)
TEST_PPAPI_OUT_OF_PROCESS(OutputProtectionPrivate)
#endif
2 changes: 2 additions & 0 deletions ppapi/ppapi_sources.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,8 @@
'tests/test_tcp_socket.h',
'tests/test_tcp_socket_private.cc',
'tests/test_tcp_socket_private.h',
'tests/test_test_internals.cc',
'tests/test_test_internals.h',
'tests/test_trace_event.cc',
'tests/test_trace_event.h',
'tests/test_truetype_font.cc',
Expand Down
Loading

0 comments on commit 6d85286

Please sign in to comment.