Skip to content

Commit

Permalink
Disable container overflow check on Linux and Mac.
Browse files Browse the repository at this point in the history
BUG=459632
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/951083002

Cr-Commit-Position: refs/heads/master@{#317681}
  • Loading branch information
inferno-chromium authored and Commit bot committed Feb 23, 2015
1 parent 2f1326e commit 6c3ce96
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions build/sanitizers/sanitizer_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ void _sanitizer_options_link_helper() { }
// so the slow unwinder may not work properly.
// detect_stack_use_after_return=1 - use fake stack to delay the reuse of
// stack allocations and detect stack-use-after-return errors.
// detect_container_overflow=0 - do not detect overflows in containers
// until crbug.com/459632 is fixed.
#if defined(OS_LINUX)
#if defined(GOOGLE_CHROME_BUILD)
// Default AddressSanitizer options for the official build. These do not affect
Expand All @@ -74,20 +76,22 @@ void _sanitizer_options_link_helper() { }
const char kAsanDefaultOptions[] =
"legacy_pthread_cond=1 malloc_context_size=5 strict_memcmp=0 "
"symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_container_overflow=0 ";
#else
// Default AddressSanitizer options for buildbots and non-official builds.
const char *kAsanDefaultOptions =
"strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 "
"detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_stack_use_after_return=1 ";
"detect_stack_use_after_return=1 detect_container_overflow=0 ";
#endif // GOOGLE_CHROME_BUILD

#elif defined(OS_MACOSX)
const char *kAsanDefaultOptions =
"strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 "
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_stack_use_after_return=1 detect_odr_violation=0 ";
"detect_stack_use_after_return=1 detect_odr_violation=0 "
"detect_container_overflow=0 ";
static const char kNaClDefaultOptions[] = "handle_segv=0";
static const char kNaClFlag[] = "--type=nacl-loader";
#endif // OS_LINUX
Expand Down

0 comments on commit 6c3ce96

Please sign in to comment.