forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Closure GN] Convert simple WebUI Closure Compilation to GN.
See go/closure-compile-gn for details. This CL converts the Closure Compilation from GYP to GN for the following: - cryptotoken - download_internals - md_downloads - md_extensions - md_history - md_user_manager - offline_pages - signin - webapks - welcome A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. Individual projects can be compiled via, for example, ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I401fc54ee6c5202bd27855ba28d886677e52210e Reviewed-on: https://chromium-review.googlesource.com/954772 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550956}
- Loading branch information
Showing
25 changed files
with
827 additions
and
792 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Copyright 2018 The Chromium Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
import("//third_party/closure_compiler/compile_js.gni") | ||
|
||
js_type_check("closure_compile") { | ||
deps = [ | ||
":approvedorigins", | ||
":b64", | ||
":closeable", | ||
":countdown", | ||
":errorcodes", | ||
":inherits", | ||
":origincheck", | ||
":sha256", | ||
":textfetcher", | ||
":timer", | ||
] | ||
} | ||
|
||
js_library("errorcodes") { | ||
} | ||
|
||
js_library("b64") { | ||
} | ||
|
||
js_library("approvedorigins") { | ||
} | ||
|
||
js_library("closeable") { | ||
} | ||
|
||
js_library("countdown") { | ||
} | ||
|
||
js_library("inherits") { | ||
} | ||
|
||
js_library("origincheck") { | ||
} | ||
|
||
js_library("sha256") { | ||
} | ||
|
||
js_library("textfetcher") { | ||
} | ||
|
||
js_library("timer") { | ||
} |
47 changes: 0 additions & 47 deletions
47
chrome/browser/resources/cryptotoken/compiled_resources2.gyp
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Copyright 2018 The Chromium Authors. All rights reserved. | ||
# Use of this source code is governed by a BSD-style license that can be | ||
# found in the LICENSE file. | ||
|
||
import("//third_party/closure_compiler/compile_js.gni") | ||
|
||
js_type_check("closure_compile") { | ||
deps = [ | ||
":download_internals", | ||
":download_internals_browser_proxy", | ||
":download_internals_visuals", | ||
] | ||
} | ||
|
||
js_library("download_internals") { | ||
deps = [ | ||
":download_internals_browser_proxy", | ||
"//ui/webui/resources/js:assert", | ||
"//ui/webui/resources/js:cr", | ||
"//ui/webui/resources/js:load_time_data", | ||
"//ui/webui/resources/js:util", | ||
] | ||
} | ||
|
||
js_library("download_internals_browser_proxy") { | ||
deps = [ | ||
"//ui/webui/resources/js:cr", | ||
] | ||
} | ||
|
||
js_library("download_internals_visuals") { | ||
deps = [ | ||
":download_internals_browser_proxy", | ||
"//ui/webui/resources/js:cr", | ||
] | ||
} |
33 changes: 0 additions & 33 deletions
33
chrome/browser/resources/download_internals/compiled_resources2.gyp
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 0 additions & 84 deletions
84
chrome/browser/resources/md_downloads/compiled_resources2.gyp
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.