Skip to content

Commit

Permalink
Rename _untrusted targets in third_party to use _nacl suffix
Browse files Browse the repository at this point in the history
Previously NaCl targets were using _untrusted suffix which makes the
purpose of these targets hard to understand. This CL renames some targets in src/third_party.

Also removed toolsets field from modp_b64_nacl.gyp

Review URL: https://codereview.chromium.org/138673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245176 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
sergeyu@chromium.org committed Jan 16, 2014
1 parent c60c83e commit 5c13171
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 22 deletions.
2 changes: 1 addition & 1 deletion chrome/chrome_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1690,7 +1690,7 @@
'../third_party/liblouis/nacl_wrapper/liblouis_wrapper_browsertest.cc',
],
'dependencies': [
'../third_party/liblouis/liblouis_untrusted.gyp:liblouis_test_data',
'../third_party/liblouis/liblouis_nacl.gyp:liblouis_test_data',
],
}],
],
Expand Down
2 changes: 1 addition & 1 deletion chrome/third_party/chromevox/chromevox.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
},
],
'dependencies': [
'../../../third_party/liblouis/liblouis_untrusted.gyp:liblouis_nacl_wrapper_untrusted',
'../../../third_party/liblouis/liblouis_nacl.gyp:liblouis_nacl_wrapper_nacl',
],
},
],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -11,11 +11,11 @@
['disable_nacl==0 and disable_nacl_untrusted==0', {
'targets': [
{
'target_name': 'jsoncpp_untrusted',
'target_name': 'jsoncpp_nacl',
'type': 'none',
'variables': {
'nacl_untrusted_build': 1,
'nlib_target': 'libjsoncpp_untrusted.a',
'nlib_target': 'libjsoncpp_nacl.a',
'build_newlib': 1,
},
'gcc_compile_flags': [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand Down Expand Up @@ -33,11 +33,11 @@
['disable_nacl==0 and disable_nacl_untrusted==0', {
'targets': [
{
'target_name': 'liblouis_untrusted',
'target_name': 'liblouis_nacl',
'type': 'none',
'variables': {
'nacl_untrusted_build': 1,
'nlib_target': 'liblouis_untrusted.a',
'nlib_target': 'liblouis_nacl.a',
'build_newlib': 1,
},
'compile_flags': [
Expand Down Expand Up @@ -68,7 +68,7 @@
],
},
{
'target_name': 'liblouis_nacl_wrapper_untrusted',
'target_name': 'liblouis_nacl_wrapper_nacl',
'type': 'none',
'variables': {
'nacl_untrusted_build': 1,
Expand Down Expand Up @@ -106,8 +106,8 @@
'link_flags': [
'-lppapi',
'-lppapi_cpp',
'-llouis_untrusted',
'-ljsoncpp_untrusted',
'-llouis_nacl',
'-ljsoncpp_nacl',
'-lpthread',
'-lnacl_io',
],
Expand All @@ -117,8 +117,8 @@
'../../native_client_sdk/native_client_sdk_untrusted.gyp:nacl_io_untrusted',
'../../ppapi/native_client/native_client.gyp:ppapi_lib',
'../../ppapi/ppapi_untrusted.gyp:ppapi_cpp_lib',
'../jsoncpp/jsoncpp_untrusted.gyp:jsoncpp_untrusted',
'liblouis_untrusted',
'../jsoncpp/jsoncpp_nacl.gyp:jsoncpp_nacl',
'liblouis_nacl',
],
'actions': [
{
Expand Down Expand Up @@ -161,7 +161,7 @@
'test_extension_dir': '<(DEPTH)/chrome/test/data/chromeos/liblouis_nacl',
},
'dependencies': [
'liblouis_nacl_wrapper_untrusted',
'liblouis_nacl_wrapper_nacl',
],
'copies': [
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -8,18 +8,17 @@
],
'targets': [
{
'target_name': 'modp_b64_untrusted',
'target_name': 'modp_b64_nacl',
'type': 'none',
'variables': {
'nlib_target': 'libmodp_b64_untrusted.a',
'nlib_target': 'libmodp_b64_nacl.a',
'build_glibc': 0,
'build_newlib': 1,
'build_pnacl_newlib': 1,
},
'dependencies': [
'<(DEPTH)/native_client/tools.gyp:prep_toolchain',
],
'toolsets': ['host', 'target'],
'sources': [
'modp_b64.cc',
'modp_b64.h',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2013 The Chromium Authors. All rights reserved.
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Expand All @@ -11,10 +11,10 @@
],
'targets': [
{
'target_name': 'opus_untrusted',
'target_name': 'opus_nacl',
'type': 'none',
'variables': {
'nlib_target': 'libopus_untrusted.a',
'nlib_target': 'libopus_nacl.a',
'build_glibc': 0,
'build_newlib': 0,
'build_pnacl_newlib': 1,
Expand All @@ -39,6 +39,6 @@
'sources/': [
['exclude', '/fixed/[^/]*_FIX.(h|c)$'],
],
}, # end of target 'opus_untrusted'
}, # end of target 'opus_nacl'
],
}

0 comments on commit 5c13171

Please sign in to comment.