Skip to content

Commit

Permalink
Re-enable disabled checks in resource-timing-sizes-multipart.html
Browse files Browse the repository at this point in the history
The checks of entry.encodedBodySize and entry.decodedBodySize in the
http/tests/misc/resource-timing-sizes-multipart.html layout test were
disabled because the values of those fields were nonsense.

Those fields now have meaningful values, so re-enable the checks.

BUG=631004

Change-Id: Id7902c194d03b4f26b9bdab5c891aa21cbddd01c
Reviewed-on: https://chromium-review.googlesource.com/1036965
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556379}
  • Loading branch information
ricea authored and Commit Bot committed May 7, 2018
1 parent 2d429e0 commit 4461b89
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@
function checkTransferSize(entry) {
// These comparisons are not strict because multipart responses are
// non-standard. Any reasonable answer is acceptable.
// TODO(ricea): encodedBodySize and decodedBodySize don't pass.
// Fix the code or make this test even more relaxed. See crbug.com/631004.
// assert_greater_than(entry.encodedBodySize, abePngSize - 1, 'encodedBodySize');
// assert_greater_than(entry.decodedBodySize, abePngSize - 1, 'decodedBodySize');
assert_greater_than(entry.encodedBodySize, abePngSize - 1, 'encodedBodySize');
assert_greater_than(entry.decodedBodySize, abePngSize - 1, 'decodedBodySize');
assert_greater_than(entry.transferSize, abePngSize + minHeaderSize, 'transferSize');
t.done();
}
Expand Down

0 comments on commit 4461b89

Please sign in to comment.