Coverity: Initialize member variables.

CID_COUNT=13 CID=102812,102838,102863,102867,102875,102891,102906,102924,102947,102964, 103070,103246,103259 BUG=none TEST=none R=groby Review URL: https://chromiumcodereview.appspot.com/9307114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120913 0039d316-1c4b-4281-b951-d872f2087c98
cbchan · Feb 8, 2012 · 3c810bb · 3c810bb
1 parent d6cc274
commit 3c810bb
Show file tree

Hide file tree

Showing 13 changed files with 27 additions and 13 deletions.
diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc
@@ -147,6 +147,7 @@ TraceEvent::TraceEvent()
       flags_(0) {
   arg_names_[0] = NULL;
   arg_names_[1] = NULL;
+  memset(arg_values_, 0, sizeof(arg_values_));
 }
 
 TraceEvent::TraceEvent(int thread_id,

diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc
@@ -50,7 +50,7 @@ void SerialOpenFunction::RespondOnUIThread() {
   SendResponse(true);
 }
 
-SerialCloseFunction::SerialCloseFunction() {
+SerialCloseFunction::SerialCloseFunction() : connection_id_(0) {
 }
 
 SerialCloseFunction::~SerialCloseFunction() {

diff --git a/chrome/browser/geolocation/chrome_access_token_store.cc b/chrome/browser/geolocation/chrome_access_token_store.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -30,7 +30,8 @@ class TokenLoadingJob : public base::RefCountedThreadSafe<TokenLoadingJob> {
  public:
   TokenLoadingJob(
       const AccessTokenStore::LoadAccessTokensCallbackType& callback)
-      : callback_(callback) {
+      : callback_(callback),
+        system_request_context_(NULL) {
   }
 
   void Run() {

diff --git a/chrome/browser/sessions/session_types.cc b/chrome/browser/sessions/session_types.cc
@@ -17,6 +17,7 @@ using content::NavigationEntry;
 TabNavigation::TabNavigation()
     : transition_(content::PAGE_TRANSITION_TYPED),
       type_mask_(0),
+      post_id_(-1),
       index_(-1) {
 }
 

diff --git a/content/common/gpu/media/dxva_video_decode_accelerator.cc b/content/common/gpu/media/dxva_video_decode_accelerator.cc
@@ -249,6 +249,8 @@ DXVAVideoDecodeAccelerator::DXVAVideoDecodeAccelerator(
       renderer_process_(renderer_process),
       last_input_buffer_id_(-1),
       inputs_before_decode_(0) {
+  memset(&input_stream_info_, 0, sizeof(input_stream_info_));
+  memset(&output_stream_info_, 0, sizeof(output_stream_info_));
 }
 
 DXVAVideoDecodeAccelerator::~DXVAVideoDecodeAccelerator() {

diff --git a/net/http/http_response_body_drainer.cc b/net/http/http_response_body_drainer.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -14,7 +14,8 @@
 namespace net {
 
 HttpResponseBodyDrainer::HttpResponseBodyDrainer(HttpStream* stream)
-    : stream_(stream),
+    : read_size_(0),
+      stream_(stream),
       next_state_(STATE_NONE),
       total_read_(0),
       session_(NULL) {}

diff --git a/net/proxy/proxy_script_decider.cc b/net/proxy/proxy_script_decider.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -49,7 +49,8 @@ ProxyScriptDecider::ProxyScriptDecider(
     ProxyScriptFetcher* proxy_script_fetcher,
     DhcpProxyScriptFetcher* dhcp_proxy_script_fetcher,
     NetLog* net_log)
-    : proxy_script_fetcher_(proxy_script_fetcher),
+    : resolver_(NULL),
+      proxy_script_fetcher_(proxy_script_fetcher),
       dhcp_proxy_script_fetcher_(dhcp_proxy_script_fetcher),
       current_pac_source_index_(0u),
       pac_mandatory_(false),

diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc
@@ -13,6 +13,7 @@ BufferedSpdyFramer::BufferedSpdyFramer()
       header_buffer_used_(0),
       header_buffer_valid_(false),
       header_stream_id_(SpdyFramer::kInvalidStream) {
+  memset(header_buffer_, 0, sizeof(header_buffer_));
 }
 
 BufferedSpdyFramer::~BufferedSpdyFramer() {

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.cc b/ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.cc
@@ -1,16 +1,18 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.h"
 
 #include <stdlib.h>
+#include <string.h>
 
 namespace ppapi_proxy {
 
 PPP_Instance_Combined::PPP_Instance_Combined()
     : initialized_(false),
       did_change_view_1_0_(NULL) {
+  memset(&instance_1_1_, 0, sizeof(instance_1_1_));
 }
 
 void PPP_Instance_Combined::Init1_0(const PPP_Instance_1_0* instance_if) {

diff --git a/ppapi/native_client/src/trusted/plugin/module_ppapi.cc b/ppapi/native_client/src/trusted/plugin/module_ppapi.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011 The Chromium Authors. All rights reserved.
+ * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
@@ -19,7 +19,9 @@ namespace plugin {
 
 class ModulePpapi : public pp::Module {
  public:
-  ModulePpapi() : pp::Module(), init_was_successful_(false) {
+  ModulePpapi() : pp::Module(),
+                  init_was_successful_(false),
+                  private_interface_(NULL) {
     MODULE_PRINTF(("ModulePpapi::ModulePpapi (this=%p)\n",
                    static_cast<void*>(this)));
   }

diff --git a/remoting/protocol/jingle_session_manager.cc b/remoting/protocol/jingle_session_manager.cc
@@ -31,6 +31,7 @@ JingleSessionManager::JingleSessionManager(
     base::MessageLoopProxy* message_loop)
     : message_loop_(message_loop),
       signal_strategy_(NULL),
+      listener_(NULL),
       allow_nat_traversal_(false),
       ready_(false),
       http_port_allocator_(NULL),

diff --git a/remoting/protocol/negotiating_authenticator.cc b/remoting/protocol/negotiating_authenticator.cc
@@ -72,7 +72,8 @@ scoped_ptr<Authenticator> NegotiatingAuthenticator::CreateForHost(
 
 NegotiatingAuthenticator::NegotiatingAuthenticator(
     Authenticator::State initial_state)
-    : current_method_(AuthenticationMethod::Invalid()),
+    : certificate_sent_(false),
+      current_method_(AuthenticationMethod::Invalid()),
       state_(initial_state),
       rejection_reason_(INVALID_CREDENTIALS) {
 }

diff --git a/webkit/plugins/ppapi/audio_helper.cc b/webkit/plugins/ppapi/audio_helper.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -14,7 +14,7 @@ namespace ppapi {
 
 // AudioHelper -----------------------------------------------------------------
 
-AudioHelper::AudioHelper() {
+AudioHelper::AudioHelper() : shared_memory_size_for_create_callback_(0) {
 }
 
 AudioHelper::~AudioHelper() {