Skip to content

Commit

Permalink
Make version info get stored in the correct resource for chrome_frame…
Browse files Browse the repository at this point in the history
…_helper.exe and chrome_frame_helper.dll.

Switch to using '1' as the version resource name since that is less fragile against #include path mix ups, etc.

BUG=65354
TEST=NONE
Review URL: http://codereview.chromium.org/7324054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92053 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
robertshield@chromium.org committed Jul 11, 2011
1 parent ba9648c commit 2d76394
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion chrome_frame/chrome_frame_helper_version.rc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// Version
//

VS_VERSION_INFO VERSIONINFO
1 VERSIONINFO
FILEVERSION CHROME_VERSION
PRODUCTVERSION CHROME_VERSION
FILEFLAGSMASK 0x17L
Expand Down
4 changes: 1 addition & 3 deletions chrome_frame/chrome_tab_version.rc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#include "version.h"

#include "winresrc.h"

#ifdef APSTUDIO_INVOKED
# error Do not open this in the GUI, it will be massacred on save. Do not do it.
#endif // APSTUDIO_INVOKED
Expand All @@ -11,7 +9,7 @@
// Version
//

VS_VERSION_INFO VERSIONINFO
1 VERSIONINFO
FILEVERSION CHROME_VERSION
PRODUCTVERSION CHROME_VERSION
FILEFLAGSMASK 0x17L
Expand Down

0 comments on commit 2d76394

Please sign in to comment.