linux: build with -Wextra

95% of this is removing "const" from return types, but turning this
on found one bug!  (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)

BUG=34160

Review URL: http://codereview.chromium.org/570012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98

base/base.gypi

@@ -1,4 +1,4 @@
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -607,6 +607,9 @@
           'cflags': [
             '-Wno-sign-compare',
           ],
+          'cflags!': [
+            '-Wextra',
+          ],
           'sources': [
             'third_party/symbolize/symbolize.cc',
             'third_party/symbolize/demangle.cc',
@@ -615,6 +618,9 @@
         {
           'target_name': 'xdg_mime',
           'type': '<(library)',
+          'cflags!': [
+            '-Wextra',
+          ],
           'sources': [
             'third_party/xdg_mime/xdgmime.c',
             'third_party/xdg_mime/xdgmime.h',

base/stack_container.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -72,7 +72,7 @@ class StackAllocator : public std::allocator<T> {
 
   // For the straight up copy c-tor, we can share storage.
   StackAllocator(const StackAllocator<T, stack_capacity>& rhs)
-      : source_(rhs.source_) {
+      : std::allocator<T>(), source_(rhs.source_) {
   }
 
   // ISO C++ requires the following constructor to be defined,

base/string_util.cc

@@ -1182,6 +1182,24 @@ struct IntToStringT {
     }
   };
 
+  // This set of templates is very similar to the above templates, but
+  // for testing whether an integer is negative.
+  template <typename INT2, bool NEG2>
+  struct TestNegT { };
+  template <typename INT2>
+  struct TestNegT<INT2, false> {
+    static bool TestNeg(INT2 value) {
+      // value is unsigned, and can never be negative.
+      return false;
+    }
+  };
+  template <typename INT2>
+  struct TestNegT<INT2, true> {
+    static bool TestNeg(INT2 value) {
+      return value < 0;
+    }
+  };
+
   static STR IntToString(INT value) {
     // log10(2) ~= 0.3 bytes needed per bit or per byte log10(2**8) ~= 2.4.
     // So round up to allocate 3 output characters per byte, plus 1 for '-'.
@@ -1191,7 +1209,7 @@ struct IntToStringT {
     // then return the substr of what we ended up using.
     STR outbuf(kOutputBufSize, 0);
 
-    bool is_neg = value < 0;
+    bool is_neg = TestNegT<INT, NEG>::TestNeg(value);
     // Even though is_neg will never be true when INT is parameterized as
     // unsigned, even the presence of the unary operation causes a warning.
     UINT res = ToUnsignedT<INT, UINT, NEG>::ToUnsigned(value);

build/common.gypi

@@ -1,4 +1,4 @@
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -602,6 +602,12 @@
           '-pthread',
           '-fno-exceptions',
           '-Wall',
+          # TODO(evan): turn this back on once the v8 change lands.
+          #'-Wextra',
+          # Don't warn about unused function params.  We use those everywhere.
+          '-Wno-unused-parameter',
+          # Don't warn about the "struct foo f = {0};" initialization pattern.
+          '-Wno-missing-field-initializers',
           '-D_FILE_OFFSET_BITS=64',
           # Don't export any symbols (for example, to plugins we dlopen()).
           # Note: this is *required* to make some plugins work.

build/external_code.gypi

@@ -1,4 +1,4 @@
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -8,6 +8,7 @@
       'target_defaults': {
         'cflags!': [
           '-Wall',
+          '-Wextra',
           '-Werror',
         ],
       },

chrome/browser/autocomplete/autocomplete.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -233,19 +233,19 @@ class AutocompleteInput {
   const GURL& canonicalized_url() const { return canonicalized_url_; }
 
   // Returns whether inline autocompletion should be prevented.
-  const bool prevent_inline_autocomplete() const {
+  bool prevent_inline_autocomplete() const {
     return prevent_inline_autocomplete_;
   }
 
   // Returns whether, given an input string consisting solely of a substituting
   // keyword, we should score it like a non-substituting keyword.
-  const bool prefer_keyword() const { return prefer_keyword_; }
+  bool prefer_keyword() const { return prefer_keyword_; }
 
   // Returns whether providers should avoid scheduling asynchronous work.  If
   // this is true, providers should stop after returning all the
   // synchronously-available matches.  This also means any in-progress
   // asynchronous work should be canceled, so no later callbacks are fired.
-  const bool synchronous_only() const { return synchronous_only_; }
+  bool synchronous_only() const { return synchronous_only_; }
 
   // operator==() by another name.
   bool Equals(const AutocompleteInput& other) const;
@@ -778,7 +778,7 @@ class AutocompleteController : public ACProviderListener {
   // This next is temporary and should go away when
   // AutocompletePopup::URLsForCurrentSelection() moves to the controller.
   const AutocompleteResult& latest_result() const { return latest_result_; }
-  const bool done() const { return done_ && !update_delay_timer_.IsRunning(); }
+  bool done() const { return done_ && !update_delay_timer_.IsRunning(); }
 
   // From AutocompleteProvider::Listener
   virtual void OnProviderUpdate(bool updated_matches);

chrome/browser/autofill/address.cc

@@ -153,7 +153,8 @@ void Address::set_line2(const string16& line2) {
 }
 
 Address::Address(const Address& address)
-    : line1_tokens_(address.line1_tokens_),
+    : FormGroup(),
+      line1_tokens_(address.line1_tokens_),
       line2_tokens_(address.line2_tokens_),
       line1_(address.line1_),
       line2_(address.line2_),

chrome/browser/autofill/address_field.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -161,7 +161,8 @@ AddressField::AddressField()
 }
 
 AddressField::AddressField(const AddressField& field)
-    : address1_(field.address1_),
+    : FormField(),
+      address1_(field.address1_),
       address2_(field.address2_),
       city_(field.city_),
       state_(field.state_),

chrome/browser/autofill/autofill_profile.cc

@@ -32,7 +32,8 @@ AutoFillProfile::AutoFillProfile()
       use_billing_address_(true) {
 }
 
-AutoFillProfile::AutoFillProfile(const AutoFillProfile& source) {
+AutoFillProfile::AutoFillProfile(const AutoFillProfile& source)
+    : FormGroup() {
   operator=(source);
 }
 

chrome/browser/autofill/contact_info.cc

@@ -150,7 +150,8 @@ string16 ContactInfo::MiddleInitial() const {
 }
 
 ContactInfo::ContactInfo(const ContactInfo& contact_info)
-    : first_tokens_(contact_info.first_tokens_),
+    : FormGroup(),
+      first_tokens_(contact_info.first_tokens_),
       middle_tokens_(contact_info.middle_tokens_),
       last_tokens_(contact_info.last_tokens_),
       first_(contact_info.first_),

chrome/browser/autofill/credit_card.cc

@@ -33,7 +33,7 @@ CreditCard::CreditCard(const string16& label, int unique_id)
       unique_id_(unique_id) {
 }
 
-CreditCard::CreditCard(const CreditCard& card) {
+CreditCard::CreditCard(const CreditCard& card) : FormGroup() {
   operator=(card);
 }
 

chrome/browser/autofill/credit_card_field.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -153,7 +153,8 @@ CreditCardField::CreditCardField()
 }
 
 CreditCardField::CreditCardField(const CreditCardField& field)
-    : cardholder_(field.cardholder_),
+    : FormField(),
+      cardholder_(field.cardholder_),
       cardholder_last_(field.cardholder_last_),
       type_(field.type_),
       number_(field.number_),

chrome/browser/autofill/name_field.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -152,7 +152,8 @@ FirstLastNameField::FirstLastNameField()
 }
 
 FirstLastNameField::FirstLastNameField(const FirstLastNameField& field)
-    : first_name_(field.first_name_),
+    : NameField(),
+      first_name_(field.first_name_),
       middle_name_(field.middle_name_),
       last_name_(field.last_name_),
       middle_initial_(field.middle_initial_) {

chrome/browser/autofill/phone_number.cc

@@ -130,7 +130,8 @@ void PhoneNumber::set_number(const string16& number) {
 }
 
 PhoneNumber::PhoneNumber(const PhoneNumber& phone_number)
-    : country_code_(phone_number.country_code_),
+    : FormGroup(),
+      country_code_(phone_number.country_code_),
       city_code_(phone_number.city_code_),
       number_(phone_number.number_),
       extension_(phone_number.extension_) {

chrome/browser/browser_theme_pack.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -171,7 +171,7 @@ PersistingImagesTable kPersistingImages[] = {
   { 59, IDR_LOCATIONBG, NULL }
 };
 
-const int GetPersistentIDByName(const std::string& key) {
+int GetPersistentIDByName(const std::string& key) {
   for (size_t i = 0; i < arraysize(kPersistingImages); ++i) {
     if (kPersistingImages[i].key != NULL &&
         base::strcasecmp(key.c_str(), kPersistingImages[i].key) == 0) {
@@ -182,7 +182,7 @@ const int GetPersistentIDByName(const std::string& key) {
   return -1;
 }
 
-const int GetPersistentIDByIDR(int idr) {
+int GetPersistentIDByIDR(int idr) {
   for (size_t i = 0; i < arraysize(kPersistingImages); ++i) {
     if (kPersistingImages[i].idr_id == idr) {
       return kPersistingImages[i].persistent_id;

chrome/browser/character_encoding.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -112,12 +112,11 @@ class CanonicalEncodingMap {
   const IdToCanonicalEncodingNameMapType* GetIdToCanonicalEncodingNameMapData();
   const CanonicalEncodingNameToIdMapType* GetCanonicalEncodingNameToIdMapData();
   const CanonicalNameDisplayNameMapType* GetCanonicalNameDisplayNameMapData();
-  std::vector<int>* const locale_dependent_encoding_ids() {
+  std::vector<int>* locale_dependent_encoding_ids() {
     return &locale_dependent_encoding_ids_;
   }
 
-  std::vector<CharacterEncoding::EncodingInfo>* const
-      current_display_encodings() {
+  std::vector<CharacterEncoding::EncodingInfo>* current_display_encodings() {
     return &current_display_encodings_;
   }
 

chrome/browser/debugger/devtools_remote_message.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -48,7 +48,7 @@ class DevToolsRemoteMessage {
     return content_;
   }
 
-  const int content_length() const {
+  int content_length() const {
     return content_.size();
   }
 

chrome/browser/dom_ui/dom_ui.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -89,11 +89,11 @@ class DOMUI {
 
   // Returns the transition type that should be used for link clicks on this
   // DOM UI. This will default to LINK but may be overridden.
-  const PageTransition::Type link_transition_type() const {
+  PageTransition::Type link_transition_type() const {
     return link_transition_type_;
   }
 
-  const int bindings() const {
+  int bindings() const {
     return bindings_;
   }
 

chrome/browser/dom_ui/most_visited_handler.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -264,8 +264,8 @@ void MostVisitedHandler::RemovePinnedURL(const GURL& url) {
   // Don't call HandleGetMostVisited. Let the client call this as needed.
 }
 
-const bool MostVisitedHandler::GetPinnedURLAtIndex(const int index,
-    MostVisitedPage* page) {
+bool MostVisitedHandler::GetPinnedURLAtIndex(int index,
+                                             MostVisitedPage* page) {
   // This iterates over all the pinned URLs. It might seem like it is worth
   // having a map from the index to the item but the number of items is limited
   // to the number of items the most visited section is showing on the NTP so

chrome/browser/dom_ui/most_visited_handler.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -86,7 +86,7 @@ class MostVisitedHandler : public DOMMessageHandler,
 
   // Gets the page data for a pinned URL at a given index. This returns
   // true if found.
-  const bool GetPinnedURLAtIndex(const int index, MostVisitedPage* page);
+  bool GetPinnedURLAtIndex(int index, MostVisitedPage* page);
 
   void AddPinnedURL(const MostVisitedPage& page, int index);
   void RemovePinnedURL(const GURL& url);

chrome/browser/dom_ui/new_tab_ui.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -47,7 +47,7 @@ class NewTabUI : public DOMUI,
                                       const GURL& gurl);
 
   // The current preference version.
-  static const int current_pref_version() { return current_pref_version_; }
+  static int current_pref_version() { return current_pref_version_; }
 
   class NewTabHTMLSource : public ChromeURLDataManager::DataSource {
    public:

chrome/browser/notifications/balloon_collection.cc

@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -121,9 +121,8 @@ BalloonCollectionImpl::Layout::Layout() {
   RefreshSystemMetrics();
 }
 
-const void BalloonCollectionImpl::Layout::GetMaxLinearSize(
-    int* max_balloon_size,
-    int* total_size) const {
+void BalloonCollectionImpl::Layout::GetMaxLinearSize(int* max_balloon_size,
+                                                     int* total_size) const {
   DCHECK(max_balloon_size && total_size);
 
   switch (placement_) {