Skip to content

Commit

Permalink
Fixed return value in error path -- result instead of false.
Browse files Browse the repository at this point in the history
Found by VC++'s /analyze.

src\win8\test\ui_automation_client.cc(380) : warning C6216:
Compiler-inserted cast between semantically different integral types:
a Boolean type to HRESULT.

BUG=427616

Review URL: https://codereview.chromium.org/768513003

Cr-Commit-Position: refs/heads/master@{#306753}
  • Loading branch information
randomascii authored and Commit bot committed Dec 4, 2014
1 parent fe8d5ce commit 131645a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion win8/test/ui_automation_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ HRESULT UIAutomationClient::Context::InvokeDesiredItem(
var.Reset();
if (FAILED(result)) {
LOG(ERROR) << std::hex << result;
return false;
return result;
}

var.Set(item_name_.c_str());
Expand Down

0 comments on commit 131645a

Please sign in to comment.