Skip to content

Commit

Permalink
Remove the base.gyp dependency from system.gyp
Browse files Browse the repository at this point in the history
The dependency is unnecessary and causes build error in the standalone webrtc project due to missing base.gyp when SCTP is enabled (it depends on usrsctp.gyp, which depends on system.gyp). All system.typ needs from base.gyp is the "include_dirs" pointing to ".." relative to "base". So we can remove the dependency on base.gyp and add "include_dirs":["../.."] instead.

BUG=

Review URL: https://codereview.chromium.org/128933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243863 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jiayl@chromium.org committed Jan 9, 2014
1 parent e666f18 commit 1179800
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions build/linux/system.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,6 @@
{
'target_name': 'libbrlapi',
'type': 'static_library',
'dependencies': [
'../../base/base.gyp:base',
],
'all_dependent_settings': {
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)',
Expand All @@ -435,6 +432,9 @@
}],
],
},
'include_dirs': [
'../..',
],
'hard_dependency': 1,
'actions': [
{
Expand Down

0 comments on commit 1179800

Please sign in to comment.