Remove empty definitions of OnKeyboardClosed()

Now there's a default empty body, so no need to override with another empty body. Bug: Change-Id: Ic089e628e44e41dd3c1d0891fd8640f4e9eea89d Reviewed-on: https://chromium-review.googlesource.com/795396 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521249}
cbchan · Dec 4, 2017 · 0e98bdf · 0e98bdf
1 parent da009d1
commit 0e98bdf
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 14 deletions.
diff --git a/ash/app_list/app_list_presenter_delegate.cc b/ash/app_list/app_list_presenter_delegate.cc
@@ -265,8 +265,6 @@ void AppListPresenterDelegate::OnKeyboardWorkspaceOccludedBoundsChanging(
   UpdateBounds();
 }
 
-void AppListPresenterDelegate::OnKeyboardClosed() {}
-
 ////////////////////////////////////////////////////////////////////////////////
 // AppListPresenterDelegate, ShellObserver implementation:
 void AppListPresenterDelegate::OnOverviewModeStarting() {

diff --git a/ash/app_list/app_list_presenter_delegate.h b/ash/app_list/app_list_presenter_delegate.h
@@ -67,7 +67,6 @@ class ASH_EXPORT AppListPresenterDelegate
   // KeyboardControllerObserver overrides:
   void OnKeyboardWorkspaceOccludedBoundsChanging(
       const gfx::Rect& new_bounds) override;
-  void OnKeyboardClosed() override;
 
   // ShellObserver overrides:
   void OnOverviewModeStarting() override;

diff --git a/ash/system/virtual_keyboard/virtual_keyboard_tray.cc b/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
@@ -100,8 +100,6 @@ void VirtualKeyboardTray::OnKeyboardBoundsChanging(
   SetIsActive(!new_bounds.IsEmpty());
 }
 
-void VirtualKeyboardTray::OnKeyboardClosed() {}
-
 void VirtualKeyboardTray::OnKeyboardControllerCreated() {
   ObserveKeyboardController();
 }

diff --git a/ash/system/virtual_keyboard/virtual_keyboard_tray.h b/ash/system/virtual_keyboard/virtual_keyboard_tray.h
@@ -37,7 +37,6 @@ class VirtualKeyboardTray : public TrayBackgroundView,
 
   // keyboard::KeyboardControllerObserver:
   void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override;
-  void OnKeyboardClosed() override;
 
   // ShellObserver:
   void OnKeyboardControllerCreated() override;

diff --git a/ash/wm/system_modal_container_layout_manager.cc b/ash/wm/system_modal_container_layout_manager.cc
@@ -140,8 +140,6 @@ void SystemModalContainerLayoutManager::
   PositionDialogsAfterWorkAreaResize();
 }
 
-void SystemModalContainerLayoutManager::OnKeyboardClosed() {}
-
 bool SystemModalContainerLayoutManager::IsPartOfActiveModalWindow(
     aura::Window* window) {
   return modal_window() &&

diff --git a/ash/wm/system_modal_container_layout_manager.h b/ash/wm/system_modal_container_layout_manager.h
@@ -52,7 +52,6 @@ class ASH_EXPORT SystemModalContainerLayoutManager
   // Overridden from keyboard::KeyboardControllerObserver:
   void OnKeyboardWorkspaceOccludedBoundsChanging(
       const gfx::Rect& new_bounds) override;
-  void OnKeyboardClosed() override;
 
   // True if the window is either contained by the top most modal window,
   // or contained by its transient children.

diff --git a/components/arc/ime/arc_ime_service.cc b/components/arc/ime/arc_ime_service.cc
@@ -289,8 +289,6 @@ void ArcImeService::OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) {
   ime_bridge_->SendOnKeyboardBoundsChanging(bounds_in_px);
 }
 
-void ArcImeService::OnKeyboardClosed() {}
-
 ////////////////////////////////////////////////////////////////////////////////
 // Overridden from ui::TextInputClient:
 

diff --git a/components/arc/ime/arc_ime_service.h b/components/arc/ime/arc_ime_service.h
@@ -96,7 +96,6 @@ class ArcImeService : public KeyedService,
 
   // Overridden from keyboard::KeyboardControllerObserver.
   void OnKeyboardBoundsChanging(const gfx::Rect& rect) override;
-  void OnKeyboardClosed() override;
 
   // Overridden from ui::TextInputClient:
   void SetCompositionText(const ui::CompositionText& composition) override;

diff --git a/ui/keyboard/keyboard_test_util.cc b/ui/keyboard/keyboard_test_util.cc
@@ -49,8 +49,6 @@ class ControllerStateChangeWaiter
   void Wait() { run_loop_.Run(); }
 
  private:
-  void OnKeyboardBoundsChanging(const gfx::Rect& new_bounds) override {}
-  void OnKeyboardClosed() override {}
   void OnStateChanged(const keyboard::KeyboardControllerState state) override {
     if (state == state_) {
       run_loop_.QuitWhenIdle();