Skip to content

Commit

Permalink
Revert 60082 - Add a PhishingClassifier implementation.
Browse files Browse the repository at this point in the history
The PhishingClassifier ties together the feature extractors and the scorer,
and will be invoked by the RenderView when a page finishes loading.  This
change also makes the feature extractors have a non-owned pointer to the clock
so that it can be shared, and fixes a problem where the DOM feature extractor
cleared out any already-present features.

BUG=none
TEST=PhishingClassifierTest

Review URL: http://codereview.chromium.org/3452010

TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/3436026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60091 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
rdsmith@chromium.org committed Sep 21, 2010
1 parent 402f193 commit 0d9440e
Show file tree
Hide file tree
Showing 11 changed files with 39 additions and 483 deletions.
2 changes: 0 additions & 2 deletions chrome/chrome_renderer.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@
'renderer/safe_browsing/feature_extractor_clock.h',
'renderer/safe_browsing/features.cc',
'renderer/safe_browsing/features.h',
'renderer/safe_browsing/phishing_classifier.cc',
'renderer/safe_browsing/phishing_classifier.h',
'renderer/safe_browsing/phishing_dom_feature_extractor.cc',
'renderer/safe_browsing/phishing_dom_feature_extractor.h',
'renderer/safe_browsing/phishing_term_feature_extractor.cc',
Expand Down
3 changes: 0 additions & 3 deletions chrome/chrome_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -1368,7 +1368,6 @@
'renderer/renderer_about_handler_unittest.cc',
'renderer/renderer_main_unittest.cc',
'renderer/safe_browsing/features_unittest.cc',
'renderer/safe_browsing/mock_feature_extractor_clock.h',
'renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc',
'renderer/safe_browsing/phishing_url_feature_extractor_unittest.cc',
'renderer/safe_browsing/scorer_unittest.cc',
Expand Down Expand Up @@ -1796,8 +1795,6 @@
'renderer/pepper_devices_browsertest.cc',
'renderer/render_view_browsertest.cc',
'renderer/render_view_browsertest_mac.mm',
'renderer/safe_browsing/mock_feature_extractor_clock.h',
'renderer/safe_browsing/phishing_classifier_browsertest.cc',
'renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc',
'renderer/safe_browsing/render_view_fake_resources_test.cc',
'renderer/safe_browsing/render_view_fake_resources_test.h',
Expand Down
28 changes: 0 additions & 28 deletions chrome/renderer/safe_browsing/mock_feature_extractor_clock.h

This file was deleted.

168 changes: 0 additions & 168 deletions chrome/renderer/safe_browsing/phishing_classifier.cc

This file was deleted.

124 changes: 0 additions & 124 deletions chrome/renderer/safe_browsing/phishing_classifier.h

This file was deleted.

Loading

0 comments on commit 0d9440e

Please sign in to comment.