ElementVisibilityObserver: get rid of reference cycle.

BUG=627539 R=mlamouri@chromium.org,zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2146383002 Cr-Commit-Position: refs/heads/master@{#405619}
cbchan · Jul 14, 2016 · 0adb974 · 0adb974
1 parent eb0a50c
commit 0adb974
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
@@ -25,14 +25,14 @@ void ElementVisibilityObserver::start()
         Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), &m_element->document(),
         WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, wrapWeakPersistent(this)));
     DCHECK(m_intersectionObserver);
-    m_intersectionObserver->observe(m_element);
+    m_intersectionObserver->observe(m_element.release());
 }
 
 void ElementVisibilityObserver::stop()
 {
     DCHECK(m_intersectionObserver);
 
-    m_intersectionObserver->unobserve(m_element);
+    m_intersectionObserver->disconnect();
     m_intersectionObserver = nullptr;
 }
 

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
@@ -36,7 +36,7 @@ class CORE_EXPORT IntersectionObserver final : public GarbageCollectedFinalized<
     // API methods.
     void observe(Element*, ExceptionState& = ASSERT_NO_EXCEPTION);
     void unobserve(Element*, ExceptionState& = ASSERT_NO_EXCEPTION);
-    void disconnect(ExceptionState&);
+    void disconnect(ExceptionState& = ASSERT_NO_EXCEPTION);
     HeapVector<Member<IntersectionObserverEntry>> takeRecords(ExceptionState&);
 
     // API attributes.