Skip to content

Commit

Permalink
Added value to ServiceUtilityProcessHostEventType to track when utili…
Browse files Browse the repository at this point in the history
…ty process failed to start.

BUG=408184
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/556823004

Cr-Commit-Position: refs/heads/master@{#295030}
  • Loading branch information
vitalybuka authored and Commit bot committed Sep 16, 2014
1 parent cf70ebc commit 0616009
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions chrome/service/service_utility_process_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ enum ServiceUtilityProcessHostEvent {
SERVICE_UTILITY_SEMANTIC_CAPS_REQUEST,
SERVICE_UTILITY_SEMANTIC_CAPS_SUCCEEDED,
SERVICE_UTILITY_SEMANTIC_CAPS_FAILED,
SERVICE_UTILITY_FAILED_TO_START,
SERVICE_UTILITY_EVENT_MAX,
};
} // namespace
Expand Down Expand Up @@ -187,6 +188,9 @@ bool ServiceUtilityProcessHost::StartProcess(
SERVICE_UTILITY_EVENT_MAX);
return true;
}
UMA_HISTOGRAM_ENUMERATION("CloudPrint.ServiceUtilityProcessHostEvent",
SERVICE_UTILITY_FAILED_TO_START,
SERVICE_UTILITY_EVENT_MAX);
return false;
}

Expand Down
1 change: 1 addition & 0 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49581,6 +49581,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="8" label="SERVICE_UTILITY_SEMANTIC_CAPS_REQUEST"/>
<int value="9" label="SERVICE_UTILITY_SEMANTIC_CAPS_SUCCEEDED"/>
<int value="10" label="SERVICE_UTILITY_SEMANTIC_CAPS_FAILED"/>
<int value="11" label="SERVICE_UTILITY_FAILED_TO_START"/>
</enum>

<enum name="ServiceWorkerDatabaseStatus" type="int">
Expand Down

0 comments on commit 0616009

Please sign in to comment.